Skip to content

Update Azure Cloud Shell API to the newer version#17115

Merged
DHowett merged 1 commit intomainfrom
dev/pabhoj/cloud_shell_update
Apr 24, 2024
Merged

Update Azure Cloud Shell API to the newer version#17115
DHowett merged 1 commit intomainfrom
dev/pabhoj/cloud_shell_update

Conversation

@PankajBhojwani
Copy link
Contributor

@PankajBhojwani PankajBhojwani commented Apr 23, 2024

Updates the api-version to 2023-02-01-preview when requesting for CloudShell settings and shell

Validation Steps Performed

Can still use Azure Cloud Shell through Windows Terminal

@PankajBhojwani
Copy link
Contributor Author

PankajBhojwani commented Apr 23, 2024 •
edited
Loading

A few things to note:

  • The new api-version introduces some new user settings, the main one being allowing Ephemeral sessions, which differs from Mounted sessions in that ephemeral sessions have no storage associated with them. As long as the user updates their user settings in the Azure portal to use ephemeral sessions, they will be able to use ephemeral sessions through Windows Terminal as well (with this change)
  • We continue to not provide any user flow to change the azure cloud shell settings (so the user cannot change between ephemeral or mounted sessions within Windows Terminal, the same way they cannot change the preferred shell type)
  • Users that haven't updated their azure cloud shell settings in the portal recently will be unaffected by this change (the new api-version is backward compatible with their old settings)
  • Users who have updated their azure cloud shell settings in the portal but don't update Terminal with this commit will be unable to use Azure Cloud Shell via Terminal - we will attempt to access their new settings with the old api-version and that will fail

@DHowett DHowett enabled auto-merge April 23, 2024 23:03
@DHowett DHowett added this pull request to the merge queue Apr 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 24, 2024
@DHowett DHowett added this pull request to the merge queue Apr 24, 2024
@DHowett DHowett removed this pull request from the merge queue due to a manual request Apr 24, 2024
@DHowett DHowett merged commit ce4e0df into main Apr 24, 2024
@DHowett DHowett deleted the dev/pabhoj/cloud_shell_update branch April 24, 2024 00:17
DHowett pushed a commit that referenced this pull request Apr 26, 2024
@PankajBhojwani @DHowett
Update Azure Cloud Shell API to the newer version (#17115)
bf0bc91 
Updates the `api-version` to `2023-02-01-preview` when requesting for
CloudShell settings and shell

## Validation Steps Performed
Can still use Azure Cloud Shell through Windows Terminal

(cherry picked from commit ce4e0df)
Service-Card-Id: 92411551
Service-Version: 1.19
DHowett pushed a commit that referenced this pull request Apr 26, 2024
@PankajBhojwani @DHowett
Update Azure Cloud Shell API to the newer version (#17115)
7bb70b0 
Updates the `api-version` to `2023-02-01-preview` when requesting for
CloudShell settings and shell

## Validation Steps Performed
Can still use Azure Cloud Shell through Windows Terminal

(cherry picked from commit ce4e0df)
Service-Card-Id: 92411552
Service-Version: 1.20
Zionsammy
Zionsammy reviewed May 7, 2024
View reviewed changes
Copy link

@Zionsammy Zionsammy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DHowett DHowett DHowett approved these changes

@lhecker lhecker lhecker approved these changes

+1 more reviewer

@Zionsammy Zionsammy Zionsammy left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

No open projects
1.19 Servicing Pipeline
Status: Cherry Picked
1.20 Servicing Pipeline
Status: Shipped

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@PankajBhojwani @DHowett @lhecker @Zionsammy