Fix TerminalPage not being released on window close#17107
Merged
Conversation
zadjii-msft
approved these changes
Apr 23, 2024
DHowett
approved these changes
Apr 23, 2024
DHowett
pushed a commit
that referenced
this pull request
Apr 23, 2024
Because this holds onto the root element, `TerminalPage` gets "leaked" on Windows 10 when a window is closed until another is opened. ## Validation Steps Performed * Set a breakpoint in `Renderer::~Renderer` * Open and close a window * Breakpoint used to not get hit and now it does ✅ (cherry picked from commit a590a1b) Service-Card-Id: 92407667 Service-Version: 1.20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because this holds onto the root element,
TerminalPagegets "leaked"on Windows 10 when a window is closed until another is opened.
Validation Steps Performed
Renderer::~Renderer