Skip to content

Update CommandPalette.cpp to ignore _filterTextChanged on TabSwitchMode#16858

Merged
DHowett merged 4 commits intomicrosoft:mainfrom
AlejandroBlanco2001:next_prev_tab_command_fix
Mar 14, 2024
Merged

Update CommandPalette.cpp to ignore _filterTextChanged on TabSwitchMode#16858
DHowett merged 4 commits intomicrosoft:mainfrom
AlejandroBlanco2001:next_prev_tab_command_fix

Conversation

@AlejandroBlanco2001
Copy link
Contributor

@AlejandroBlanco2001 AlejandroBlanco2001 commented Mar 10, 2024

Summary of the Pull Request

As mentioned in the issue #11146, when the "Next/Prev" command is executed from the command line with a string in the search bar, this is setting always the first tab.

References and Relevant Issues

#11146

Detailed Description of the Pull Request / Additional comments

When using the command "Next/Previous Tab" from the command line, we are creating another tab (as if we are using the keyboard shortcut), and this triggers the _filterTextChanged that resets the index to the first item in because the current mode that it has.

This could be cause because, It seems that it detects as if we are deleting the entered letter or creating an empty string, causing the execution of the mentioned method and resetting its index to 0.

To avoid this, we are making sure that when this action is triggerd and we are in the TabSwitchMode, we should ignore the following execution of the method.

Validation Steps Performed

I tested out the following scenarios:

  1. Performing the action with the keyboard shorcut
  2. Perfoming the action with an empty string
  3. Performing the action with a string in the search bar.

Also validated with the current tests.

PowerShell.2024-03-10.21-43-29.mp4

PR Checklist

@microsoft-github-policy-service microsoft-github-policy-service bot added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Priority-2 A description (P2) Product-Terminal The new Windows Terminal. labels Mar 10, 2024
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@DHowett DHowett enabled auto-merge (squash) March 14, 2024 19:57
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! Sorry for the delay - it's our company hackathon this week, so folks have their attention elsewhere :)

@DHowett DHowett merged commit 806d5e2 into microsoft:main Mar 14, 2024
DHowett pushed a commit that referenced this pull request Mar 21, 2024
…de (#16858)

As mentioned in #11146, when the "Next/Prev" command is executed from
the command line with a string in the search bar, this is setting always
the first tab.

When using the command "Next/Previous Tab" from the command line, we are
creating another tab (as if we are using the keyboard shortcut), and
this triggers the `_filterTextChanged` that resets the index to the
first item in because the current mode that it has.

This could be cause because, It seems that it detects as if we are
deleting the entered letter or creating an empty string, causing the
execution of the mentioned method and resetting its index to 0.

To avoid this, we are making sure that when this action is triggerd and
we are in the `TabSwitchMode`, we should ignore the following execution
of the method.

## Validation Steps Performed
I tested out the following scenarios:
1. Performing the action with the keyboard shorcut
2. Perfoming the action with an empty string
3. Performing the action with a string in the search bar.

Also validated with the current tests.

Closes #11146

(cherry picked from commit 806d5e2)
Service-Card-Id: 92139800
Service-Version: 1.20
DHowett pushed a commit that referenced this pull request Mar 21, 2024
…de (#16858)

As mentioned in #11146, when the "Next/Prev" command is executed from
the command line with a string in the search bar, this is setting always
the first tab.

When using the command "Next/Previous Tab" from the command line, we are
creating another tab (as if we are using the keyboard shortcut), and
this triggers the `_filterTextChanged` that resets the index to the
first item in because the current mode that it has.

This could be cause because, It seems that it detects as if we are
deleting the entered letter or creating an empty string, causing the
execution of the mentioned method and resetting its index to 0.

To avoid this, we are making sure that when this action is triggerd and
we are in the `TabSwitchMode`, we should ignore the following execution
of the method.

## Validation Steps Performed
I tested out the following scenarios:
1. Performing the action with the keyboard shorcut
2. Perfoming the action with an empty string
3. Performing the action with a string in the search bar.

Also validated with the current tests.

Closes #11146

(cherry picked from commit 806d5e2)
Service-Card-Id: 92139799
Service-Version: 1.19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal.

Projects

No open projects
Status: Cherry Picked

Development

Successfully merging this pull request may close these issues.

Next and Prev tab command palette actions can only focus the first tab

3 participants