Skip to content

Add an action for manually invoking the control context menu#15254

Merged
DHowett merged 5 commits intomainfrom
dev/migrie/f/context-menu-action
May 11, 2023
Merged

Add an action for manually invoking the control context menu#15254
DHowett merged 5 commits intomainfrom
dev/migrie/f/context-menu-action

Conversation

@zadjii-msft
Copy link
Member

Adds

        { "command": "showContextMenu", "keys": "menu" },

as a default action. This will manually invoke the control context menu (from #14775), even with the setting disabled.

As discussed with Dustin.

DHowett added a commit that referenced this pull request Apr 27, 2023
…l context menu

# Conflicts:
#	src/cascadia/TerminalApp/AppActionHandlers.cpp
Copy link
Member

@lhecker lhecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There be a bug in the DIPs. Arrrr 🏴‍☠️

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Apr 28, 2023
@zadjii-msft zadjii-msft self-assigned this May 1, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label May 1, 2023
@zadjii-msft zadjii-msft added this to the Terminal v1.18 milestone May 1, 2023
@zadjii-msft zadjii-msft assigned lhecker and unassigned zadjii-msft May 3, 2023
@DHowett DHowett changed the title this adds an action for manually invoking the control context menu Add an action for manually invoking the control context menu May 11, 2023
@DHowett DHowett merged commit 076c36c into main May 11, 2023
@DHowett DHowett deleted the dev/migrie/f/context-menu-action branch May 11, 2023 03:32
PKRoma pushed a commit to PKRoma/Terminal that referenced this pull request May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants