Add the ability to select a whole command (or its output)#14807
Merged
zadjii-msft merged 24 commits intomainfrom Apr 20, 2023
Merged
Add the ability to select a whole command (or its output)#14807zadjii-msft merged 24 commits intomainfrom
zadjii-msft merged 24 commits intomainfrom
Conversation
lhecker
reviewed
Feb 13, 2023
zadjii-msft
added a commit
that referenced
this pull request
Mar 11, 2023
…b.com/microsoft/terminal into dev/migrie/f/4588-select-shell-output
(cherry picked from commit 275f3de)
lhecker
requested changes
Apr 11, 2023
Member
lhecker
left a comment
There was a problem hiding this comment.
I'm not particularly comfortable with the boolean logic in the loops. I feel like they're fairly hard to understand and reason about. Unless my suggestion is incorrect, I would personally strongly prefer if something that's more arithmetic was used (like in my suggestion).
lhecker
approved these changes
Apr 19, 2023
DHowett
reviewed
Apr 20, 2023
| void ControlCore::SelectCommand(const bool goUp) | ||
| { | ||
| const til::point start = HasSelection() ? (goUp ? _terminal->GetSelectionAnchor() : _terminal->GetSelectionEnd()) : | ||
| _terminal->GetTextBuffer().GetCursor().GetPosition(); |
Member
There was a problem hiding this comment.
i wonder if this should have anchored near the bottom of the viewport instead - wdyt?
| } | ||
| } | ||
|
|
||
| void ControlCore::SelectOutput(const bool goUp) |
Member
There was a problem hiding this comment.
these seem to be the same function with a one-line difference
Comment on lines
+84
to
+85
| void SelectCommand(const bool goUp); | ||
| void SelectOutput(const bool goUp); |
Member
There was a problem hiding this comment.
IMO these two names are too generic for the "public" interface of TermControl, and should be made more specific. SelectMarkedCommand or SelectMarkedOutput or something (though, mark mode makes the distinction confusing)
| { ShortcutAction::AdjustFontSize, RS_(L"AdjustFontSizeCommandKey") }, | ||
| { ShortcutAction::CloseOtherPanes, RS_(L"CloseOtherPanesCommandKey") }, | ||
| { ShortcutAction::CloseOtherTabs, L"" }, // Intentionally omitted, must be generated by GenerateName | ||
| { ShortcutAction::CloseOtherTabs, MustGenerate }, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two new commands,
selectOutputandselectCommand. These don't do much without shell integration enabled, unfortunately. If you do enable it, however, you can use these commands to quickly navigate the history to select whole commands (or their output).Some sample JSON:
{ "keys": "ctrl+shift+<", "command": { "action": "selectCommand", "direction": "prev" } }, { "keys": "ctrl+shift+>", "command": { "action": "selectCommand", "direction": "next" } }, { "keys": "ctrl+shift+[", "command": { "action": "selectOutput", "direction": "prev" } }, { "keys": "ctrl+shift+]", "command": { "action": "selectOutput", "direction": "next" } },Demo gifs in #4588 (comment)
closes #4588
Tested manually.
CMD.exe user? It's dangerous to go alone! Take this.
Surely, there's a simpler way to do it, this is adapted from my own script.