Skip to content

Fix the Release build ProxyStubClsids from #13570#14225

Merged
1 commit merged intomainfrom
dev/duhowett/11th-hour
Oct 15, 2022
Merged

Fix the Release build ProxyStubClsids from #13570#14225
1 commit merged intomainfrom
dev/duhowett/11th-hour

Conversation

@DHowett
Copy link
Member

@DHowett DHowett commented Oct 14, 2022

These were wrong.

@lhecker lhecker added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-Build Issues pertaining to the build system, CI, infrastructure, meta Product-Terminal The new Windows Terminal. AutoMerge Marked for automatic merge by the bot when requirements are met Needs-Second It's a PR that needs another sign-off Priority-0 Bugs that we consider release-blocking/recall-class (P0) labels Oct 15, 2022
@ghost
Copy link

ghost commented Oct 15, 2022

Hello @lhecker!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 6 hours 2 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 1f19ed0 into main Oct 15, 2022
@ghost ghost deleted the dev/duhowett/11th-hour branch October 15, 2022 07:58
DHowett added a commit that referenced this pull request Oct 17, 2022
@DHowett
Fix the Release build ProxyStubClsids from #13570 (#14225)
0dccbac 
These were wrong.

(cherry picked from commit 1f19ed0)
Service-Card-Id: 86230901
Service-Version: 1.16
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lhecker lhecker lhecker approved these changes

@carlos-zamora carlos-zamora carlos-zamora approved these changes

@zadjii-msft zadjii-msft Awaiting requested review from zadjii-msft

@PankajBhojwani PankajBhojwani Awaiting requested review from PankajBhojwani

Assignees

No one assigned

Labels

Area-Build Issues pertaining to the build system, CI, infrastructure, meta AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Second It's a PR that needs another sign-off Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-Terminal The new Windows Terminal.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DHowett @lhecker @carlos-zamora