Skip to content

Don't set full screen to quake window#13473

Merged
1 commit merged intomicrosoft:mainfrom
davidegiacometti:issue-12894
Jul 11, 2022
Merged

Don't set full screen to quake window#13473
1 commit merged intomicrosoft:mainfrom
davidegiacometti:issue-12894

Conversation

@davidegiacometti
Copy link
Contributor

@davidegiacometti davidegiacometti commented Jul 9, 2022

If launch mode is set to full screen quake window is opened in full
screen.

Validation Steps Performed

  • Set startup > launch mode > full screen
  • Launch quake window
  • Quake window shouldn't be opened in full screen

Closes #12894

@ghost ghost added Area-Windowing Window frame, quake mode, tearout Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels Jul 9, 2022
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@DHowett DHowett added the AutoMerge Marked for automatic merge by the bot when requirements are met label Jul 11, 2022
@ghost
Copy link

ghost commented Jul 11, 2022

Hello @DHowett!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 589286a into microsoft:main Jul 11, 2022
@davidegiacometti davidegiacometti deleted the issue-12894 branch July 11, 2022 19:33
DHowett pushed a commit that referenced this pull request Jul 15, 2022
If launch mode is set to full screen quake window is opened in full
screen.

## Validation Steps Performed
- Set startup > launch mode > full screen
- Launch quake window
- Quake window shouldn't be opened in full screen

Closes #12894

(cherry picked from commit 589286a)
Service-Card-Id: 84116409
Service-Version: 1.14
DHowett pushed a commit that referenced this pull request Jul 19, 2022
If launch mode is set to full screen quake window is opened in full
screen.

## Validation Steps Performed
- Set startup > launch mode > full screen
- Launch quake window
- Quake window shouldn't be opened in full screen

Closes #12894

(cherry picked from commit 589286a)
Service-Card-Id: 84116410
Service-Version: 1.15
@ghost
Copy link

ghost commented Aug 5, 2022

🎉Windows Terminal v1.14.196 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Aug 5, 2022

🎉Windows Terminal Preview v1.15.200 has been released which incorporates this pull request.:tada:

Handy links:

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Windowing Window frame, quake mode, tearout AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setting launch mode to full screen also applies to Quake mode

4 participants