Teach command palette to fill in selected commandline upon right arrow#11069
Teach command palette to fill in selected commandline upon right arrow#110692 commits merged intomicrosoft:mainfrom
Conversation
zadjii-msft
left a comment
There was a problem hiding this comment.
Okay checked out the branch - I love it. This is exactly what I wanted
|
Can one-a-ya share a GIF? 😄 |
|
|
|
/me smashes that merge button |
| _searchBox().Select(_searchBox().Text().size(), 0); | ||
| _searchBox().Focus(FocusState::Programmatic); | ||
| _filteredActionsView().SelectedIndex(-1); | ||
| e.Handled(true); |
There was a problem hiding this comment.
Same question as @Rosefield, actually -- this doesn't break left/right in the general case, right? For editing the command once you pop it in the box?
There was a problem hiding this comment.
I believe the change as is is fine since it only handles the right array key if you have something selected, and it deselects the option after you hit right arrow the first time.
|
@msftbot merge this in 1 minute |
|
Hello @DHowett! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
The first time you open commandline mode, `recentCommands` doesn't exist yet. However, we immediately try to read the `Size()` in a couple places. This'll A/V and we'll crash 😨 The fix is easy - don't try and read the size of the non-existent `recentCommands` Found this while playing with #11069 Regressed in #11030 Didn't bother filing an issue for it when I have the fix in hand
|
🎉 Handy links: |
Closes #11049