[A11y] Initialize and copy _blockRange in UIA Clone#10544
Merged
2 commits merged intoJul 6, 2021
Merged
Conversation
carlos-zamora
commented
Jul 2, 2021
Member
|
Careful with the terminology. RuntimeClassInitialize isn't actually a "constructor" in the C++ sense specifically! |
Member
Author
Fixed! |
lhecker
approved these changes
Jul 2, 2021
lhecker
left a comment
Member
There was a problem hiding this comment.
When Resharper comes out for VS 2022, we should all buy it together.
It has a clang-tidy integration that actually works. 😐
lhecker
reviewed
Jul 2, 2021
miniksa
reviewed
Jul 6, 2021
miniksa
requested changes
Jul 6, 2021
miniksa
left a comment
Member
There was a problem hiding this comment.
Waiting for pending comments to be complete.
DHowett
approved these changes
Jul 6, 2021
miniksa
approved these changes
Jul 6, 2021
|
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
DHowett
pushed a commit
that referenced
this pull request
Jul 7, 2021
## Summary of the Pull Request #7960 was caused by `UiaTextRangeBase::_blockRange` not being initialized, thus pointing to random memory. In most cases, we initialize it properly in `RuntimeClassInitialize`, however, the copying version of `RuntimeClassInitialize` doesn't actually copy it over, resulting in it still containing random memory. NVDA (and other screen readers) occasionally use `Clone` (really just the copy initializer), resulting in this bug occurring randomly. ## PR Checklist * [X] Closes #7960 * [X] Tests added/passed ## Validation Steps Performed Test failed before the change, but passes after the change. (cherry picked from commit 79a18f0)
DHowett
pushed a commit
that referenced
this pull request
Jul 7, 2021
## Summary of the Pull Request #7960 was caused by `UiaTextRangeBase::_blockRange` not being initialized, thus pointing to random memory. In most cases, we initialize it properly in `RuntimeClassInitialize`, however, the copying version of `RuntimeClassInitialize` doesn't actually copy it over, resulting in it still containing random memory. NVDA (and other screen readers) occasionally use `Clone` (really just the copy initializer), resulting in this bug occurring randomly. ## PR Checklist * [X] Closes #7960 * [X] Tests added/passed ## Validation Steps Performed Test failed before the change, but passes after the change. (cherry picked from commit 79a18f0)
|
🎉 Handy links: |
|
🎉 Handy links: |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
#7960 was caused by
UiaTextRangeBase::_blockRangenot being initialized, thus pointing to random memory. In most cases, we initialize it properly inRuntimeClassInitialize, however, the copying version ofRuntimeClassInitializedoesn't actually copy it over, resulting in it still containing random memory.NVDA (and other screen readers) occasionally use
Clone(really just the copy initializer), resulting in this bug occurring randomly.PR Checklist
Validation Steps Performed
Test failed before the change, but passes after the change.