Skip to content

[1.15+] Flushing FTCS sequences causes flickering in nushell 0.66+ #13710

@rgwood

Description

@rgwood

Windows Terminal version

1.15.2003.0

Windows build number

Microsoft Windows [Version 10.0.22000.795]

Other Software

Nushell v0.66+

Steps to reproduce

Hi, I work on a cross-platform shell called Nushell and we've noticed a rendering regression in Windows Terminal Preview v1.15.

Nushell's prompt now flickers on every keystroke. The following recording illustrates the problem (but it's a little worse in real life, the recording didn't capture every flicker):

2022-08-09_11-27-44.mp4

To reproduce this, run any version of Nushell from v0.66 or later and start typing. Nushell can be downloaded from our GitHub releases or installed with Scoop (scoop install nushell) or winget (winget install nushell). nu.exe is the executable for Nushell.

Details / Investigation

The flickering does not occur in Windows Terminal v1.14.1963.0.

We bisected Nushell's code and found that the flickering did not occur prior to this PR which added some scroll mark ANSI escape codes for VS Code. WT v1.15 Preview added experimental support for scroll marks; maybe this is a bug in the experimental scroll mark code?

The flickering occurs even with the scroll mark settings (experimental.autoMarkPrompts and experimental.showMarksOnScrollbar) set to false.

If there's anything else we can do to help with investigation or reproduction, just let me know!

Metadata

Metadata

Assignees

Labels

Area-VTVirtual Terminal sequence supportIn-PRThis issue has a related PRIssue-BugIt either shouldn't be doing this or needs an investigation.Needs-Tag-FixDoesn't match tag requirementsProduct-ConptyFor console issues specifically related to conpty

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions