Skip to content

add more shell integration ansi escapes in support of vscode#6087

Merged
fdncred merged 2 commits intonushell:mainfrom
fdncred:more_shell_integration_for_vscode
Jul 20, 2022
Merged

add more shell integration ansi escapes in support of vscode#6087
fdncred merged 2 commits intonushell:mainfrom
fdncred:more_shell_integration_for_vscode

Conversation

@fdncred
Copy link
Contributor

@fdncred fdncred commented Jul 20, 2022

Description

This PR supports more shell integration ansi escapes so we can see little blue, gray, red dots in vscode's terminal.

Tests

Make sure you've done the following:

  • Add tests that cover your changes, either in the command examples, the crate/tests folder, or in the /tests folder.
  • Try to think about corner cases and various ways how your changes could break. Cover them with tests.
  • If adding tests is not possible, please document in the PR body a minimal example with steps on how to reproduce so one can verify your change works.

Make sure you've run and fixed any issues with these commands:

  • cargo fmt --all -- --check to check standard code formatting (cargo fmt --all applies these changes)
  • cargo clippy --workspace --features=extra -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect to check that you're using the standard code style
  • cargo test --workspace --features=extra to check that all the tests pass

Copy link

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks 🙂

@fdncred
Copy link
Contributor Author

fdncred commented Jul 20, 2022

Let's GO!

@fdncred
Copy link
Contributor Author

fdncred commented Jul 20, 2022

Thanks so much for your help @Tyriar!!!

@fdncred fdncred merged commit 98126e2 into nushell:main Jul 20, 2022
@fdncred fdncred deleted the more_shell_integration_for_vscode branch July 20, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants