Add new relative time skills for ' ago' and 'last '#927
Merged
dluc merged 33 commits intomicrosoft:mainfrom May 25, 2023
Merged
Add new relative time skills for ' ago' and 'last '#927dluc merged 33 commits intomicrosoft:mainfrom
dluc merged 33 commits intomicrosoft:mainfrom
Conversation
…emantic-kernel into timgill/newtimeskills
lemillermicrosoft
suggested changes
May 12, 2023
Member
lemillermicrosoft
left a comment
There was a problem hiding this comment.
Great idea! Overall LGTM -- some build warnings in the test file that need to be cleaned up.
Member
Author
|
Updated to remove the warnings in my code - there appears to be one still there from a nuget which I did not add. |
lemillermicrosoft
previously approved these changes
May 12, 2023
dluc
reviewed
May 12, 2023
dotnet/src/SemanticKernel.UnitTests/CoreSkills/TimeSkillTests.cs
Outdated
Show resolved
Hide resolved
53734e0 to
252058c
Compare
Co-authored-by: Devis Lucato <dluc@users.noreply.github.com>
lemillermicrosoft
previously approved these changes
May 19, 2023
dluc
reviewed
May 25, 2023
dluc
reviewed
May 25, 2023
dluc
approved these changes
May 25, 2023
shawncal
pushed a commit
to shawncal/semantic-kernel
that referenced
this pull request
Jul 6, 2023
### Motivation and Context The change enables the planner to make use of time references like "last wednesday" or "three days ago" which currently cause issues. This enables better use of SequentialPlanner when servicing user intent. Issue: microsoft#922 ### Description This adds two new functions to the core TimeSkill class in both .net and python. 1. DaysAgo(str days) - takes an argument representing a number of days and offsets it from the current date to return the resultant date as the answer. 2. LastMatchingDay(str dayName) - takes the name of a day of the week and works backwards from yesterday to give it the first matching date of that day (e.g. "last wednesday"). Currently it only works with English day names, and this is reflected in the prompt description. Simple unit tests are added for each function. Co-authored-by: Devis Lucato <dluc@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The change enables the planner to make use of time references like "last wednesday" or "three days ago" which currently cause issues. This enables better use of SequentialPlanner when servicing user intent.
Issue: #922
Description
This adds two new functions to the core TimeSkill class in both .net and python.
Simple unit tests are added for each function.
Contribution Checklist
dotnet format