Skip to content

Conversation

@eavanvalkenburg
Copy link
Member

Motivation and Context

Adds unit test run only for ubuntu for python 3.13, should not fail full job when it does fail.
Slight improvement of filename handling for the coverage.

Description

Contribution Checklist

@eavanvalkenburg eavanvalkenburg requested a review from a team as a code owner July 11, 2024 12:33
@markwallace-microsoft markwallace-microsoft added the python Pull requests for the Python Semantic Kernel label Jul 11, 2024
@markwallace-microsoft
Copy link
Member

markwallace-microsoft commented Jul 11, 2024

Py3.10 Test Coverage

Python 3.10 Test Coverage Report •
FileStmtsMissCoverMissing
semantic_kernel/connectors/ai
   prompt_execution_settings.py53198%49
TOTAL681841594% 

Python 3.10 Unit Test Overview

Tests Skipped Failures Errors Time
1731 1 💤 0 ❌ 0 🔥 30.411s ⏱️

@eavanvalkenburg eavanvalkenburg added this pull request to the merge queue Jul 11, 2024
Merged via the queue into microsoft:main with commit 8a23c26 Jul 11, 2024
@eavanvalkenburg eavanvalkenburg deleted the exp_3.13 branch July 11, 2024 16:47
LudoCorporateShark pushed a commit to LudoCorporateShark/semantic-kernel that referenced this pull request Aug 25, 2024
### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
Adds unit test run only for ubuntu for python 3.13, should not fail full
job when it does fail.
Slight improvement of filename handling for the coverage.

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python Pull requests for the Python Semantic Kernel

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants