-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Python: added singular get methods #7202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Python 3.10 Test Coverage Report •
Python 3.10 Unit Test Overview
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
juliomenendez
approved these changes
Jul 11, 2024
python/semantic_kernel/connectors/ai/chat_completion_client_base.py
Outdated
Show resolved
Hide resolved
1481bec to
78c41ea
Compare
TaoChenOSU
reviewed
Jul 11, 2024
python/semantic_kernel/connectors/ai/chat_completion_client_base.py
Outdated
Show resolved
Hide resolved
TaoChenOSU
reviewed
Jul 11, 2024
python/semantic_kernel/connectors/ai/open_ai/services/open_ai_text_embedding_base.py
Show resolved
Hide resolved
glahaye
approved these changes
Jul 11, 2024
f74c76e to
428d9a7
Compare
moonbox3
approved these changes
Jul 11, 2024
juliomenendez
approved these changes
Jul 11, 2024
Co-authored-by: Tao Chen <taochen@microsoft.com>
428d9a7 to
b572fdc
Compare
moonbox3
approved these changes
Jul 11, 2024
LudoCorporateShark
pushed a commit
to LudoCorporateShark/semantic-kernel
that referenced
this pull request
Aug 25, 2024
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Adds singular get_..._content methods to all services, initially implemented by calling the multi version and passing back the first result, it therefore does not check on the number of responses parameter, just provides the interface. Also add `generate_raw_embeddings` to Embedding Base to allow models to return different types, while keeping generate_embeddings to return a numpy array. Fixes microsoft#6926 ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Tao Chen <taochen@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Adds singular get_..._content methods to all services, initially implemented by calling the multi version and passing back the first result, it therefore does not check on the number of responses parameter, just provides the interface.
Also add
generate_raw_embeddingsto Embedding Base to allow models to return different types, while keeping generate_embeddings to return a numpy array.Fixes #6926
Description
Contribution Checklist