Skip to content

Conversation

@moonbox3
Copy link
Collaborator

@moonbox3 moonbox3 commented Jul 9, 2024

Motivation and Context

We have mypy enabled on parts of the code base, but not all. The goal is to enable it across the entire SK python code. As part of this, we've broken up the work to tackle different sections. Additionally, we're working to improve the code coverage for these sections of code.

Description

This PR:

  • turns on mypy for the connector utils and the search connectors (Bing and Google). Small Code adjustments were made per mypy.
  • other refactoring to make the code cleaner like using https AsyncClient, and better error handling around the API call.
  • introduces Google Search settings for the connector.
  • adds more unit test coverage for the document loader util and the Bing/Google search connectors. There is 100% code coverage.
  • closes Python: CQ Spike: Utils & Search Engine #7136

Contribution Checklist

@moonbox3 moonbox3 requested a review from a team as a code owner July 9, 2024 00:24
@markwallace-microsoft markwallace-microsoft added the python Pull requests for the Python Semantic Kernel label Jul 9, 2024
@markwallace-microsoft
Copy link
Member

Py3.10 Test Coverage

Python 3.10 Test Coverage Report •
FileStmtsMissCoverMissing
semantic_kernel/connectors/search_engine
   bing_connector.py443325%38, 47–99
   google_connector.py372630%22–29, 33–65
semantic_kernel/connectors/utils
   document_loader.py17194%27
TOTAL666462391% 

Python 3.10 Unit Test Overview

Tests Skipped Failures Errors Time
1644 1 💤 0 ❌ 0 🔥 24.461s ⏱️

@moonbox3 moonbox3 enabled auto-merge July 9, 2024 14:17
@moonbox3 moonbox3 added this pull request to the merge queue Jul 9, 2024
Merged via the queue into microsoft:main with commit 44d47ac Jul 9, 2024
@moonbox3 moonbox3 deleted the utils_search_code_quality branch July 9, 2024 15:19
LudoCorporateShark pushed a commit to LudoCorporateShark/semantic-kernel that referenced this pull request Aug 25, 2024
…e code quality. (microsoft#7163)

### Motivation and Context

We have mypy enabled on parts of the code base, but not all. The goal is
to enable it across the entire SK python code. As part of this, we've
broken up the work to tackle different sections. Additionally, we're
working to improve the code coverage for these sections of code.

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

### Description

This PR:
- turns on mypy for the connector utils and the search connectors (Bing
and Google). Small Code adjustments were made per mypy.
- other refactoring to make the code cleaner like using https
AsyncClient, and better error handling around the API call.
- introduces Google Search settings for the connector.
- adds more unit test coverage for the document loader util and the
Bing/Google search connectors. There is 100% code coverage.
- closes microsoft#7136

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [X] The code builds clean without any errors or warnings
- [X] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [X] All unit tests pass, and I have added new tests where possible
- [X] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python Pull requests for the Python Semantic Kernel

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Python: CQ Spike: Utils & Search Engine

4 participants