-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Python: Turn on mypy for OpenAPI plugins. Increase code coverage. #7153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Python 3.10 Test Coverage Report •
Python 3.10 Unit Test Overview
|
||||||||||||||||||||||||||||||||||||||||||||||||||
TaoChenOSU
reviewed
Jul 8, 2024
python/semantic_kernel/connectors/openapi_plugin/models/rest_api_operation.py
Outdated
Show resolved
Hide resolved
Member
eavanvalkenburg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small question, otherwise looks great!
python/semantic_kernel/connectors/openapi_plugin/openapi_manager.py
Outdated
Show resolved
Hide resolved
eavanvalkenburg
approved these changes
Jul 8, 2024
Member
eavanvalkenburg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
juliomenendez
approved these changes
Jul 8, 2024
TaoChenOSU
approved these changes
Jul 8, 2024
glahaye
reviewed
Jul 8, 2024
glahaye
reviewed
Jul 8, 2024
python/semantic_kernel/connectors/openapi_plugin/models/rest_api_operation.py
Show resolved
Hide resolved
glahaye
approved these changes
Jul 8, 2024
LudoCorporateShark
pushed a commit
to LudoCorporateShark/semantic-kernel
that referenced
this pull request
Aug 25, 2024
…crosoft#7153) ### Motivation and Context We have mypy enabled on parts of the code base, but not all. The goal is to enable it across the entire SK python code. As part of this, we've broken up the work to tackle different sections. Additionally, we're working to improve the code coverage for these sections of code. <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> ### Description This PR: - turns on mypy for the openapi connector (plugin). Code adjustments were made per mypy, with the exclusion of two places that contain a `type: ignore` as the type was already valid, but mypy still complained. - adds more unit test coverage for the OpenAPI models and classes. All OpenAPI classes are now >95% covered. - closes microsoft#7135 <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [X] The code builds clean without any errors or warnings - [X] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [X] All unit tests pass, and I have added new tests where possible - [X] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
We have mypy enabled on parts of the code base, but not all. The goal is to enable it across the entire SK python code. As part of this, we've broken up the work to tackle different sections. Additionally, we're working to improve the code coverage for these sections of code.
Description
This PR:
type: ignoreas the type was already valid, but mypy still complained.Contribution Checklist