.Net: Updated audio abstractions to return multiple values#5149
Merged
rogerbarreto merged 5 commits intomicrosoft:mainfrom Feb 26, 2024
Merged
.Net: Updated audio abstractions to return multiple values#5149rogerbarreto merged 5 commits intomicrosoft:mainfrom
rogerbarreto merged 5 commits intomicrosoft:mainfrom
Conversation
dotnet/src/IntegrationTests/Connectors/OpenAI/OpenAIAudioToTextTests.cs
Outdated
Show resolved
Hide resolved
rogerbarreto
approved these changes
Feb 26, 2024
SergeyMenshykh
approved these changes
Feb 26, 2024
rogerbarreto
approved these changes
Feb 26, 2024
LudoCorporateShark
pushed a commit
to LudoCorporateShark/semantic-kernel
that referenced
this pull request
Aug 25, 2024
…#5149) ### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> This PR contains changes for audio abstractions to align with abstraction pattern in SK to return multiple values instead of just one to be more flexible in cases when AI connector returns multiple results (like in chat completion service with choices). For easier usage when only one result is provided by AI connector, it's possible to use extension method that is responsible for returning single result. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
Bryan-Roe
pushed a commit
to Bryan-Roe-ai/semantic-kernel
that referenced
this pull request
Oct 6, 2024
…#5149) ### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> This PR contains changes for audio abstractions to align with abstraction pattern in SK to return multiple values instead of just one to be more flexible in cases when AI connector returns multiple results (like in chat completion service with choices). For easier usage when only one result is provided by AI connector, it's possible to use extension method that is responsible for returning single result. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR contains changes for audio abstractions to align with abstraction pattern in SK to return multiple values instead of just one to be more flexible in cases when AI connector returns multiple results (like in chat completion service with choices).
For easier usage when only one result is provided by AI connector, it's possible to use extension method that is responsible for returning single result.
Contribution Checklist