.Net AudioContent class moved to the Microsoft.SemanticKernel namespace#5112
Merged
SergeyMenshykh merged 4 commits intomicrosoft:mainfrom Feb 22, 2024
Merged
Conversation
…ce to align it with the other content classes.
dmytrostruk
approved these changes
Feb 22, 2024
Member
dmytrostruk
left a comment
There was a problem hiding this comment.
My mistake, thanks for fixing this. Pipelines are failing, since it's breaking change. I've added suppression files to proceed with merging.
Member
Author
No problem at all. We should have done a better job reviewing the PR. Thanks for adding the suppression. |
markwallace-microsoft
approved these changes
Feb 22, 2024
LudoCorporateShark
pushed a commit
to LudoCorporateShark/semantic-kernel
that referenced
this pull request
Aug 25, 2024
…ce (microsoft#5112) The AudioContent class lives in the Microsoft.SemanticKernel.Contents namespace, while the other content classes reside in the Microsoft.SemanticKernel namespace. This PR moves the AudioContent class to the Microsoft.SemanticKernel namespace to align it with the other content classes. --------- Co-authored-by: Dmytro Struk <13853051+dmytrostruk@users.noreply.github.com>
Bryan-Roe
pushed a commit
to Bryan-Roe-ai/semantic-kernel
that referenced
this pull request
Oct 6, 2024
…ce (microsoft#5112) The AudioContent class lives in the Microsoft.SemanticKernel.Contents namespace, while the other content classes reside in the Microsoft.SemanticKernel namespace. This PR moves the AudioContent class to the Microsoft.SemanticKernel namespace to align it with the other content classes. --------- Co-authored-by: Dmytro Struk <13853051+dmytrostruk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AudioContent class lives in the Microsoft.SemanticKernel.Contents namespace, while the other content classes reside in the Microsoft.SemanticKernel namespace. This PR moves the AudioContent class to the Microsoft.SemanticKernel namespace to align it with the other content classes.