.Net The 'Source' property added to the ChatMessageContent class#5091
Merged
SergeyMenshykh merged 7 commits intomicrosoft:mainfrom Feb 26, 2024
Merged
.Net The 'Source' property added to the ChatMessageContent class#5091SergeyMenshykh merged 7 commits intomicrosoft:mainfrom
SergeyMenshykh merged 7 commits intomicrosoft:mainfrom
Conversation
…ociate it with an instance of the service that generated it. This may be useful in agent customization scenarios to access the agent that generates messages.
SergeyMenshykh
commented
Feb 20, 2024
Contributor
|
Does we can use this property to solve plugin name problem described here #4913? |
Member
Author
I don't see, at least for now, how the property can solve the problem. Chat completion services that use the ChatMessageContent class and SK functions are two unrelated SK components/functionality. Even if it might be possible to solve the problem for a particular edge case scenario using the property, it should not be the way forward. Instead, a proper solution should be put in place that covers the majority, if not all, scenarios. |
dmytrostruk
approved these changes
Feb 26, 2024
dotnet/src/SemanticKernel.Abstractions/Contents/ChatMessageContent.cs
Outdated
Show resolved
Hide resolved
markwallace-microsoft
approved these changes
Feb 26, 2024
dmytrostruk
approved these changes
Feb 26, 2024
LudoCorporateShark
pushed a commit
to LudoCorporateShark/semantic-kernel
that referenced
this pull request
Aug 25, 2024
…rosoft#5091) ### Motivation and Context For agent customization story, when converting or translating messages from one agent to another, we need a way to access the agent that generated the messages. ### Description This PR adds the 'Source' property to the ChatMessageContent class. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
Bryan-Roe
pushed a commit
to Bryan-Roe-ai/semantic-kernel
that referenced
this pull request
Oct 6, 2024
…rosoft#5091) ### Motivation and Context For agent customization story, when converting or translating messages from one agent to another, we need a way to access the agent that generated the messages. ### Description This PR adds the 'Source' property to the ChatMessageContent class. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
For agent customization story, when converting or translating messages from one agent to another, we need a way to access the agent that generated the messages.
Description
This PR adds the 'Source' property to the ChatMessageContent class.
Contribution Checklist