Adding HandlebarsPlanCreationException#4973
Merged
teresaqhoang merged 6 commits intomicrosoft:mainfrom Feb 23, 2024
Merged
Conversation
Contributor
|
But isn't this a return to how kernel errors were once handled? ADR 0004 describes a departure from such solution in favor of throwing exceptions. |
704cf70 to
9171a7a
Compare
Contributor
Author
Great callout @Krzysztof318, that slipped my mind. Pivoted to creating a narrower exception type containing these details. |
...et/src/Planners/Planners.Handlebars/Handlebars/Exceptions/HandlebarsPlanCreationException.cs
Outdated
Show resolved
Hide resolved
...et/src/Planners/Planners.Handlebars/Handlebars/Exceptions/HandlebarsPlanCreationException.cs
Outdated
Show resolved
Hide resolved
crickman
approved these changes
Feb 15, 2024
...et/src/Planners/Planners.Handlebars/Handlebars/Exceptions/HandlebarsPlanCreationException.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Planners/Planners.Handlebars/Handlebars/HandlebarsPlanner.cs
Outdated
Show resolved
Hide resolved
SergeyMenshykh
approved these changes
Feb 21, 2024
LudoCorporateShark
pushed a commit
to LudoCorporateShark/semantic-kernel
that referenced
this pull request
Aug 25, 2024
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Resolves microsoft#4440 This PR adds a more detailed `HandlebarsPlanCreationException` type, which allows users to inspect the prompt and model results, if available. Als includes a minor update to sample to add clarifying comments. ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> Users can catch `HandlebarsPlanCreationException` to inspect the prompt, proposed plan, and exception details on error. All exceptions will be bubbled up to the caller. ``` var planner = new HandlebarsPlanner(); try { var plan = await planner.CreatePlanAsync(kernel, intent, cancellationToken); } catch (HandlebarsPlanCreationException ex) { Console.WriteLine(ex.Message); Console.WriteLine(ex.InnerException?.Message); Console.WriteLine($"CreatePlan Prompt: {ex.CreatePlanPrompt}"); Console.WriteLine($"Proposed plan (model output): {ex.ModelResults.Content}"); throw ex; } ``` ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
Bryan-Roe
pushed a commit
to Bryan-Roe-ai/semantic-kernel
that referenced
this pull request
Oct 6, 2024
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Resolves microsoft#4440 This PR adds a more detailed `HandlebarsPlanCreationException` type, which allows users to inspect the prompt and model results, if available. Als includes a minor update to sample to add clarifying comments. ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> Users can catch `HandlebarsPlanCreationException` to inspect the prompt, proposed plan, and exception details on error. All exceptions will be bubbled up to the caller. ``` var planner = new HandlebarsPlanner(); try { var plan = await planner.CreatePlanAsync(kernel, intent, cancellationToken); } catch (HandlebarsPlanCreationException ex) { Console.WriteLine(ex.Message); Console.WriteLine(ex.InnerException?.Message); Console.WriteLine($"CreatePlan Prompt: {ex.CreatePlanPrompt}"); Console.WriteLine($"Proposed plan (model output): {ex.ModelResults.Content}"); throw ex; } ``` ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Resolves #4440
This PR adds a more detailed
HandlebarsPlanCreationExceptiontype, which allows users to inspect the prompt and model results, if available.Als includes a minor update to sample to add clarifying comments.
Description
Users can catch
HandlebarsPlanCreationExceptionto inspect the prompt, proposed plan, and exception details on error. All exceptions will be bubbled up to the caller.Contribution Checklist