Python: Add CMK support to create Index#4949
Merged
moonbox3 merged 11 commits intomicrosoft:mainfrom Feb 9, 2024
charotAmine:python-cmk
Merged
Python: Add CMK support to create Index#4949moonbox3 merged 11 commits intomicrosoft:mainfrom charotAmine:python-cmk
moonbox3 merged 11 commits intomicrosoft:mainfrom
charotAmine:python-cmk
Conversation
...antic_kernel/connectors/memory/azure_cognitive_search/azure_cognitive_search_memory_store.py
Show resolved
Hide resolved
moonbox3
reviewed
Feb 9, 2024
...antic_kernel/connectors/memory/azure_cognitive_search/azure_cognitive_search_memory_store.py
Outdated
Show resolved
Hide resolved
eavanvalkenburg
approved these changes
Feb 9, 2024
Collaborator
|
@charotAmine your change went in just in time for the latest release. Thank you for your contribution! |
eavanvalkenburg
pushed a commit
to eavanvalkenburg/semantic-kernel
that referenced
this pull request
Feb 12, 2024
### Motivation and Context
Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
1. Why is this change required?
When we try to create an index in AI Search where the encryption is
enabled we have this issue :
Code: OperationNotAllowed
Message: The creation of non-encrypted Indexes is not alowed when
encryption policy is enforced.
Which make the operation create_collection unusable
2. What problem does it solve?
Use create_collection function
3. What scenario does it contribute to?
If the customer uses the CMK for the encryption
4. If it fixes an open issue, please link to the issue here.
### Description
The Azure Search Documents supports the encryption key with the class
SearchResourceEncryptionKey, adding it (Free to the customer to use it
or not) resolve the issue.
Maybe it may be use it in save_information function as well ?
### Contribution Checklist
<!-- Before submitting this PR, please make sure: -->
- [X] The code builds clean without any errors or warnings
- [X] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [X] All unit tests pass, and I have added new tests where possible
- [X] I didn't break anyone 😄
---------
Co-authored-by: Evan Mattson <35585003+moonbox3@users.noreply.github.com>
Bryan-Roe
pushed a commit
to Bryan-Roe-ai/semantic-kernel
that referenced
this pull request
Oct 6, 2024
### Motivation and Context
Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
1. Why is this change required?
When we try to create an index in AI Search where the encryption is
enabled we have this issue :
Code: OperationNotAllowed
Message: The creation of non-encrypted Indexes is not alowed when
encryption policy is enforced.
Which make the operation create_collection unusable
2. What problem does it solve?
Use create_collection function
3. What scenario does it contribute to?
If the customer uses the CMK for the encryption
4. If it fixes an open issue, please link to the issue here.
### Description
The Azure Search Documents supports the encryption key with the class
SearchResourceEncryptionKey, adding it (Free to the customer to use it
or not) resolve the issue.
Maybe it may be use it in save_information function as well ?
### Contribution Checklist
<!-- Before submitting this PR, please make sure: -->
- [X] The code builds clean without any errors or warnings
- [X] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [X] All unit tests pass, and I have added new tests where possible
- [X] I didn't break anyone 😄
---------
Co-authored-by: Evan Mattson <35585003+moonbox3@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following information:
When we try to create an index in AI Search where the encryption is enabled we have this issue :
Code: OperationNotAllowed
Message: The creation of non-encrypted Indexes is not alowed when encryption policy is enforced.
Which make the operation create_collection unusable
Use create_collection function
If the customer uses the CMK for the encryption
Description
The Azure Search Documents supports the encryption key with the class SearchResourceEncryptionKey, adding it (Free to the customer to use it or not) resolve the issue.
Maybe it may be use it in save_information function as well ?
Contribution Checklist