Python: Fix 06 memory notebook missing plugin name.#4906
Merged
moonbox3 merged 3 commits intomicrosoft:mainfrom Feb 8, 2024
Merged
Python: Fix 06 memory notebook missing plugin name.#4906moonbox3 merged 3 commits intomicrosoft:mainfrom
moonbox3 merged 3 commits intomicrosoft:mainfrom
Conversation
juliomenendez
approved these changes
Feb 6, 2024
alliscode
approved these changes
Feb 8, 2024
Bryan-Roe
pushed a commit
to Bryan-Roe-ai/semantic-kernel
that referenced
this pull request
Oct 6, 2024
### Motivation and Context The Python 06 notebook had a failing cell due to a missing plugin_name. Also the KernelFunction wasn't visible from the semantic_kernel import due to it missing from the init file. Fixes: microsoft#4905. <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> ### Description Fix the notebook by suppling a plugin_name for the memory store. Add the KernelFunction to the sk __init__.py file. Fix a comment related to an incorrectly named PromptExecutionSetting class. <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [X] The code builds clean without any errors or warnings - [X] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [X] All unit tests pass, and I have added new tests where possible - [X] I didn't break anyone 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The Python 06 notebook had a failing cell due to a missing plugin_name. Also the KernelFunction wasn't visible from the semantic_kernel import due to it missing from the init file. Fixes: #4905.
Description
Fix the notebook by suppling a plugin_name for the memory store. Add the KernelFunction to the sk init.py file. Fix a comment related to an incorrectly named PromptExecutionSetting class.
Contribution Checklist