Skip to content

Python: Set the default plugins on the semantic function. Add a unit test.#4897

Merged
moonbox3 merged 2 commits intomicrosoft:mainfrom
moonbox3:fix_set_plugins_on_semantic_func
Feb 6, 2024
Merged

Python: Set the default plugins on the semantic function. Add a unit test.#4897
moonbox3 merged 2 commits intomicrosoft:mainfrom
moonbox3:fix_set_plugins_on_semantic_func

Conversation

@moonbox3
Copy link
Collaborator

@moonbox3 moonbox3 commented Feb 6, 2024

Motivation and Context

Fixes #4869. On a created semantic function, the plugins weren't getting set for use for the function.

Description

Set the default plugins for the registered function, and add a unit test.

Contribution Checklist

@moonbox3 moonbox3 requested a review from a team as a code owner February 6, 2024 16:48
@shawncal shawncal added the python Pull requests for the Python Semantic Kernel label Feb 6, 2024
@moonbox3 moonbox3 added this pull request to the merge queue Feb 6, 2024
Merged via the queue into microsoft:main with commit 1efeb69 Feb 6, 2024
@moonbox3 moonbox3 deleted the fix_set_plugins_on_semantic_func branch February 6, 2024 17:05
Bryan-Roe pushed a commit to Bryan-Roe-ai/semantic-kernel that referenced this pull request Oct 6, 2024
…test. (microsoft#4897)

### Motivation and Context

Fixes microsoft#4869. On a created semantic function, the plugins weren't getting
set for use for the function.

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

### Description

Set the default plugins for the registered function, and add a unit
test.

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [X] The code builds clean without any errors or warnings
- [X] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [X] All unit tests pass, and I have added new tests where possible
- [X] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python Pull requests for the Python Semantic Kernel

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Python: Error: Plugin collection not set

4 participants