Python: Fixing python document pipeline#3744
Merged
moonbox3 merged 24 commits intomicrosoft:mainfrom Feb 23, 2024
Merged
Conversation
markwallace-microsoft
approved these changes
Nov 29, 2023
moonbox3
approved these changes
Nov 29, 2023
|
Python: Fixing python document pipeline by aayush3011 · Pull Request #3744 · microsoft/semantic-kernel (github.com) |
|
It appears like all of the checks have passed, but this pr hasn't been merged. Is there anything Reference can do to assist with helping to merge it? thanks |
Collaborator
|
@KatGreenSmith there is a failing integration test while trying to merge the code to main. I'll need to look into this today. |
|
[like] Kathryn Smith reacted to your message:
…________________________________
From: Evan Mattson ***@***.***>
Sent: Wednesday, January 3, 2024 4:14:04 PM
To: microsoft/semantic-kernel ***@***.***>
Cc: Kathryn Smith ***@***.***>; Mention ***@***.***>
Subject: Re: [microsoft/semantic-kernel] Python: Fixing python document pipeline (PR #3744)
@KatGreenSmith<https://github.com/KatGreenSmith> there is a failing integration test while trying to merge the code to main.
Azure Cosmos Connection String not found in .env file
I'll need to look into this today.
—
Reply to this email directly, view it on GitHub<#3744 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AWZXZIJ2OW5YUZHNDIQ3YILYMV7UZAVCNFSM6AAAAAA77ABJ52VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZVGYYTSOBQGA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Collaborator
|
@KatGreenSmith I need a bit of time with this, please. We haven't been running any integration tests against CosmosDB resources, so I need to figure out how we should best handle this. |
|
[like] Kathryn Smith reacted to your message:
…________________________________
From: Evan Mattson ***@***.***>
Sent: Friday, January 5, 2024 9:49:23 PM
To: microsoft/semantic-kernel ***@***.***>
Cc: Kathryn Smith ***@***.***>; Mention ***@***.***>
Subject: Re: [microsoft/semantic-kernel] Python: Fixing python document pipeline (PR #3744)
@KatGreenSmith<https://github.com/KatGreenSmith> I need a bit of time with this, please. We haven't been running any integration tests against CosmosDB resources, so I need to figure out how we should best handle this.
—
Reply to this email directly, view it on GitHub<#3744 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AWZXZIO3QOCZQCEVNKNGZLLYNBYOHAVCNFSM6AAAAAA77ABJ52VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZZGI4TKMRXGM>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
…aayush3011/semantic-kernel into users/akataria/CosmosDBMemoryStoreFixes
moonbox3
requested changes
Feb 9, 2024
python/tests/integration/connectors/memory/test_azure_cosmosdb_memory_store.py
Outdated
Show resolved
Hide resolved
Collaborator
|
Hi @aayush3011, I understand these changes are needed for your work. Shall we address the last few comments so we can get this closed out? |
…aayush3011/semantic-kernel into users/akataria/CosmosDBMemoryStoreFixes
Contributor
Author
|
Hey @moonbox3, I have resolved all the comments, can you review and merge the PR. |
moonbox3
approved these changes
Feb 22, 2024
Collaborator
|
@aayush3011 we're still hitting the same integration test error that I have brought up in the past. We don't have that resource and cannot provide a connection string. |
moonbox3
approved these changes
Feb 23, 2024
moonbox3
approved these changes
Feb 23, 2024
LudoCorporateShark
pushed a commit
to LudoCorporateShark/semantic-kernel
that referenced
this pull request
Aug 25, 2024
Fixing python document pipeline --------- Co-authored-by: Mark Wallace <127216156+markwallace-microsoft@users.noreply.github.com> Co-authored-by: Evan Mattson <35585003+moonbox3@users.noreply.github.com>
Bryan-Roe
pushed a commit
to Bryan-Roe-ai/semantic-kernel
that referenced
this pull request
Oct 6, 2024
Fixing python document pipeline --------- Co-authored-by: Mark Wallace <127216156+markwallace-microsoft@users.noreply.github.com> Co-authored-by: Evan Mattson <35585003+moonbox3@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing python document pipeline