Add namespace warning suppression to KernelPlanningExtensions.cs#320
Merged
lemillermicrosoft merged 1 commit intomicrosoft:mainfrom Apr 4, 2023
Merged
Conversation
Summary: This commit adds a pragma directive to suppress the IDE0130 warning that suggests using the file name as the namespace for the KernelPlanningExtensions.cs file. This warning is not applicable for extension methods, as they need to be in the same namespace as the type they are extending. The commit also adds a using directive for the Microsoft.SemanticKernel.Planning namespace, which is needed for the extension methods.
adrianwyatt
approved these changes
Apr 4, 2023
dehoward
pushed a commit
to lemillermicrosoft/semantic-kernel
that referenced
this pull request
Jun 1, 2023
…rosoft#320) ### Motivation and Context Fix the build ### Description This commit adds a pragma directive to suppress the IDE0130 warning that suggests using the file name as the namespace for the KernelPlanningExtensions.cs file. This warning is not applicable for extension methods, as they need to be in the same namespace as the type they are extending. The commit also adds a using directive for the Microsoft.SemanticKernel.Planning namespace, which is needed for the extension methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fix the build
Description
This commit adds a pragma directive to suppress the IDE0130 warning that suggests using the file name as the namespace for the KernelPlanningExtensions.cs file. This warning is not applicable for extension methods, as they need to be in the same namespace as the type they are extending. The commit also adds a using directive for the Microsoft.SemanticKernel.Planning namespace, which is needed for the extension methods.
Contribution Checklist
dotnet format