.Net: Replacing FunctionsView class with List#2878
Merged
shawncal merged 10 commits intomicrosoft:mainfrom Sep 20, 2023
Merged
Conversation
4 tasks
lemillermicrosoft
approved these changes
Sep 19, 2023
dotnet/src/SemanticKernel.Abstractions/SkillDefinition/IReadOnlySkillCollection.cs
Outdated
Show resolved
Hide resolved
dotnet/src/SemanticKernel.Abstractions/SkillDefinition/NullReadOnlySkillCollection.cs
Outdated
Show resolved
Hide resolved
SergeyMenshykh
approved these changes
Sep 19, 2023
4 tasks
Member
|
Resolves #604 |
markwallace-microsoft
approved these changes
Sep 20, 2023
SOE-YoungS
pushed a commit
to SOE-YoungS/semantic-kernel
that referenced
this pull request
Nov 1, 2023
### Motivation and Context The `FunctionsView` class wraps two inner Dictionaries of `FunctionView` objects: Native and Semantic. Since we no longer differentiate between these two for any practical purpose, we could merge those into one list, and we no longer need a special class for that. ### Description - Removing the different collections to store Semantic vs Native functions - Removing `FunctionsView` collection - From `SkillCollection.GetFunctionsView()`, returning an `IReadOnlyList<FunctionView>` - Callers can then easily use LINQ to filter the resulting flat list, or group by skill name. - Updating callers, tests Resolves microsoft#604 ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [X] The code builds clean without any errors or warnings - [X] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [X] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄 - BREAKING CHANGE as it modifies the public API. Low impact. --------- Co-authored-by: Roger Barreto <19890735+RogerBarreto@users.noreply.github.com> Co-authored-by: Lee Miller <lemiller@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The
FunctionsViewclass wraps two inner Dictionaries ofFunctionViewobjects: Native and Semantic. Since we no longer differentiate between these two for any practical purpose, we could merge those into one list, and we no longer need a special class for that.Description
FunctionsViewcollectionSkillCollection.GetFunctionsView(), returning anIReadOnlyList<FunctionView>Resolves #604
Contribution Checklist