.Net: Milvus memory store connector for .NET#2694
Merged
lemillermicrosoft merged 9 commits intomicrosoft:mainfrom Sep 21, 2023
Merged
.Net: Milvus memory store connector for .NET#2694lemillermicrosoft merged 9 commits intomicrosoft:mainfrom
lemillermicrosoft merged 9 commits intomicrosoft:mainfrom
Conversation
stephentoub
reviewed
Sep 3, 2023
dotnet/src/Connectors/Connectors.Memory.Milvus/MilvusMemoryStore.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.Memory.Milvus/MilvusMemoryStore.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.Memory.Milvus/MilvusMemoryStore.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.Memory.Milvus/MilvusMemoryStore.cs
Outdated
Show resolved
Hide resolved
f722cf7 to
780913a
Compare
stephentoub
reviewed
Sep 13, 2023
stephentoub
approved these changes
Sep 13, 2023
Member
stephentoub
left a comment
There was a problem hiding this comment.
Nice.
@shawncal, can you help get this merged at your earliest convenience?
Member
Author
|
@shawncal ping - we'd like to move forward with this if possible... thanks! |
This commit updates the order of arguments in Assert.Equal calls in MilvusMemoryStoreTests. The expected values are now placed before the actual values, following the correct convention.
This commit fixes the order of arguments in Assert.Equal calls in MilvusMemoryStoreTests, ensuring that the expected value comes first and the actual value comes second.
lemillermicrosoft
approved these changes
Sep 21, 2023
SOE-YoungS
pushed a commit
to SOE-YoungS/semantic-kernel
that referenced
this pull request
Nov 1, 2023
This is a working version of an SK memory store connector for Milvus, for .NET. It is built on top of the recently-released [Milvus.Client](https://www.nuget.org/packages/Milvus.Client) (experimental, in preview), which uses gRPC to communicate with Milvus. There are some minor outstanding issues which are also relevant for the Python connector (merged via microsoft#1941), I'll sync with @awharrison-28 to align on these. But this should be more or less ready to merge, we can iterate on the remaining stuff. Closes microsoft#2316 /cc @stephentoub @awharrison-28 @luisquintanilla @MarianaGG @tawalke @ajcvickers --------- Co-authored-by: Shawn Callegari <36091529+shawncal@users.noreply.github.com> Co-authored-by: Lee Miller <lemiller@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a working version of an SK memory store connector for Milvus, for .NET. It is built on top of the recently-released Milvus.Client (experimental, in preview), which uses gRPC to communicate with Milvus.
There are some minor outstanding issues which are also relevant for the Python connector (merged via #1941), I'll sync with @awharrison-28 to align on these. But this should be more or less ready to merge, we can iterate on the remaining stuff.
Closes #2316
/cc @stephentoub @awharrison-28 @luisquintanilla @MarianaGG @tawalke @ajcvickers