Skip to content

Update README.md#263

Merged
dluc merged 1 commit intomicrosoft:mainfrom
Qworg:patch-1
Apr 1, 2023
Merged

Update README.md#263
dluc merged 1 commit intomicrosoft:mainfrom
Qworg:patch-1

Conversation

@Qworg
Copy link
Contributor

@Qworg Qworg commented Mar 31, 2023

Fixing the AddAzureOpenAITextCompletion call and adding required libs.

Motivation and Context

Description

Contribution Checklist

Fixing the AddAzureOpenAITextCompletion call and adding required libs.
@Qworg Qworg marked this pull request as ready for review March 31, 2023 21:31
@lemillermicrosoft
Copy link
Member

lemillermicrosoft commented Mar 31, 2023

AddAzureOpenAITextCompletionService has replaced AddAzureOpenAITextCompletion, don't think this is the right change to make. Please re-open or file an issue if there is something else going on.

Edit: Ah, probably a disconnect with nuget packages for the new stuff not quite yet being available. Taking note of this dissconnect.

@dluc dluc reopened this Apr 1, 2023
@dluc
Copy link
Contributor

dluc commented Apr 1, 2023

We are going through a few breaking changes and updated the README too soon.

Thanks for catching and fixing this @Qworg!

@dluc dluc merged commit cf1d2b4 into microsoft:main Apr 1, 2023
@lemillermicrosoft
Copy link
Member

Thanks @Qworg -- sorry for my crossing of the streams -- appreciate your help!

dehoward pushed a commit to lemillermicrosoft/semantic-kernel that referenced this pull request Jun 1, 2023
Fix README to reflect the content of the latest nuget (AddAzureOpenAITextCompletion call and required libs)
golden-aries pushed a commit to golden-aries/semantic-kernel that referenced this pull request Oct 10, 2023
### Description

When requesting `generate a table of fruits` or `generate some code to
count from 1 to 200` the response will contain markdown:

![image](https://github.com/microsoft/chat-copilot/assets/13119203/12b11e19-1e2b-4335-b45a-e3dd97919de2)

However Markdown can not be rendered in the frontend. This PR fixes it
by adding a markdown rendering library and making use of it:

![image](https://github.com/microsoft/chat-copilot/assets/13119203/726b6fe9-4673-4021-87c9-923d48a1d64d)

This also avoids using `dangerouslySetInnerHTML` attribute. The library
`remark-gfm` is used because `react-markdown` does not support tables
out of the box.

This is how urls or links would be rendered:

![image](https://github.com/microsoft/chat-copilot/assets/13119203/0b084d58-9602-4682-b5d2-ea77dbd6bbd9)
johnoliver pushed a commit to johnoliver/semantic-kernel that referenced this pull request Jun 5, 2024
Fix README to reflect the content of the latest nuget (AddAzureOpenAITextCompletion call and required libs)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants