.Net: Azure OpenAI Chat Completion with data#2498
Merged
dmytrostruk merged 32 commits intomicrosoft:mainfrom Aug 22, 2023
Merged
.Net: Azure OpenAI Chat Completion with data#2498dmytrostruk merged 32 commits intomicrosoft:mainfrom
dmytrostruk merged 32 commits intomicrosoft:mainfrom
Conversation
Member
Author
|
Received great feedback from @rogerbarreto , will convert it to draft to add missing functionality. |
…struk/semantic-kernel into chat-completion-with-data
Member
lemillermicrosoft
left a comment
There was a problem hiding this comment.
Initial review, LGTM overall. Will do more when published.
...et/src/Connectors/Connectors.AI.OpenAI/ChatCompletionWithData/AzureChatCompletionWithData.cs
Outdated
Show resolved
Hide resolved
SergeyMenshykh
approved these changes
Aug 21, 2023
...et/src/Connectors/Connectors.AI.OpenAI/ChatCompletionWithData/AzureChatCompletionWithData.cs
Outdated
Show resolved
Hide resolved
rogerbarreto
requested changes
Aug 21, 2023
dotnet/samples/KernelSyntaxExamples/Example54_AzureChatCompletionWithData.cs
Outdated
Show resolved
Hide resolved
dotnet/samples/KernelSyntaxExamples/Example54_AzureChatCompletionWithData.cs
Outdated
Show resolved
Hide resolved
dotnet/src/SemanticKernel.Abstractions/AI/ChatCompletion/ChatCompletionExtensions.cs
Outdated
Show resolved
Hide resolved
rogerbarreto
approved these changes
Aug 21, 2023
dotnet/samples/KernelSyntaxExamples/Example54_AzureChatCompletionWithData.cs
Outdated
Show resolved
Hide resolved
dotnet/samples/KernelSyntaxExamples/Example54_AzureChatCompletionWithData.cs
Outdated
Show resolved
Hide resolved
…ionWithData.cs Co-authored-by: Roger Barreto <19890735+RogerBarreto@users.noreply.github.com>
…ionWithData.cs Co-authored-by: Roger Barreto <19890735+RogerBarreto@users.noreply.github.com>
dotnet/samples/KernelSyntaxExamples/Example54_AzureChatCompletionWithData.cs
Outdated
Show resolved
Hide resolved
dotnet/samples/KernelSyntaxExamples/Example54_AzureChatCompletionWithData.cs
Outdated
Show resolved
Hide resolved
…ionWithData.cs Co-authored-by: Roger Barreto <19890735+RogerBarreto@users.noreply.github.com>
…ionWithData.cs Co-authored-by: Roger Barreto <19890735+RogerBarreto@users.noreply.github.com>
lemillermicrosoft
approved these changes
Aug 22, 2023
SOE-YoungS
pushed a commit
to SOE-YoungS/semantic-kernel
that referenced
this pull request
Nov 1, 2023
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Resolves microsoft#2326 Implementation of Azure OpenAI Chat Completion with data feature: https://learn.microsoft.com/en-us/azure/ai-services/openai/use-your-data-quickstart ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> 1. Implemented `AzureChatCompletionWithData` class, that uses `HttpClient` for API requests. 2. Added necessary internal classes for request/response serialization/deserialization. 3. Added unit tests. 4. Added usage example. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Roger Barreto <19890735+RogerBarreto@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Resolves #2326
Implementation of Azure OpenAI Chat Completion with data feature:
https://learn.microsoft.com/en-us/azure/ai-services/openai/use-your-data-quickstart
Description
AzureChatCompletionWithDataclass, that usesHttpClientfor API requests.Contribution Checklist