.Net: Adding Kusto as an external memory#2257
Merged
shawncal merged 36 commits intomicrosoft:mainfrom Aug 10, 2023
danield137:danield137-kustomem
Merged
.Net: Adding Kusto as an external memory#2257shawncal merged 36 commits intomicrosoft:mainfrom danield137:danield137-kustomem
shawncal merged 36 commits intomicrosoft:mainfrom
danield137:danield137-kustomem
Conversation
zivcaspi
reviewed
Aug 1, 2023
zivcaspi
reviewed
Aug 1, 2023
zivcaspi
reviewed
Aug 1, 2023
zivcaspi
reviewed
Aug 1, 2023
zivcaspi
reviewed
Aug 1, 2023
zivcaspi
reviewed
Aug 1, 2023
dotnet/src/Connectors/Connectors.Memory.Kusto/Connectors.Memory.Kusto.csproj
Outdated
Show resolved
Hide resolved
zivcaspi
reviewed
Aug 1, 2023
dotnet/src/Connectors/Connectors.Memory.Kusto/KustoMemoryStore.cs
Outdated
Show resolved
Hide resolved
zivcaspi
reviewed
Aug 1, 2023
dotnet/src/Connectors/Connectors.Memory.Kusto/KustoMemoryStore.cs
Outdated
Show resolved
Hide resolved
zivcaspi
reviewed
Aug 1, 2023
dotnet/src/Connectors/Connectors.Memory.Kusto/KustoMemoryStore.cs
Outdated
Show resolved
Hide resolved
Contributor
Author
|
You guys have an impressive array of auto-checks. Kudos. |
dmytrostruk
approved these changes
Aug 4, 2023
Member
dmytrostruk
left a comment
There was a problem hiding this comment.
@danield137 thank you for contribution!
I tested functionality manually using Example53_Kusto - it works as expected.
awharrison-28
approved these changes
Aug 4, 2023
shawncal
suggested changes
Aug 8, 2023
dotnet/src/Connectors/Connectors.Memory.Kusto/KustoExtensions.cs
Outdated
Show resolved
Hide resolved
shawncal
approved these changes
Aug 8, 2023
Contributor
Author
|
@shawncal , is there anything else required to in order to merge this? |
madsbolaris
pushed a commit
to madsbolaris/semantic-kernel
that referenced
this pull request
Aug 11, 2023
<!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Adding Kusto as an external memory. <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Dmytro Struk <13853051+dmytrostruk@users.noreply.github.com> Co-authored-by: Shawn Callegari <36091529+shawncal@users.noreply.github.com>
SOE-YoungS
pushed a commit
to SOE-YoungS/semantic-kernel
that referenced
this pull request
Nov 1, 2023
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> ### Description Adding Kusto as an external memory. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Dmytro Struk <13853051+dmytrostruk@users.noreply.github.com> Co-authored-by: Shawn Callegari <36091529+shawncal@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Description
Adding Kusto as an external memory.
Contribution Checklist