.Net Updating OpenAI/AzureOpenAI ModelResults to be per Choice#2214
Merged
shawncal merged 6 commits intomicrosoft:mainfrom Jul 31, 2023
Merged
Conversation
dmytrostruk
previously approved these changes
Jul 28, 2023
dotnet/samples/KernelSyntaxExamples/Example43_GetModelResult.cs
Outdated
Show resolved
Hide resolved
shawncal
approved these changes
Jul 31, 2023
SOE-YoungS
pushed a commit
to SOE-YoungS/semantic-kernel
that referenced
this pull request
Nov 1, 2023
…soft#2214) ### Motivation and Context Prior to this change, when using the ModelResult in a multiple results scenario the choices were being repeated for each ModelResult object, not being clear which Choice was related to the Result. Resolves microsoft#1658 Closes microsoft#1658 ### Description Added two new representations for both `ChatResult` and `TextResult` that has one to one reference to the `choice` details coming from the LLM. Updated GetModelResult example with the expected behavior and an easier example to track the changes and different prompts. ### Contribution Checklist - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Prior to this change, when using the ModelResult in a multiple results scenario the choices were being repeated for each ModelResult object, not being clear which Choice was related to the Result.
Resolves #1658
Closes #1658
Description
Added two new representations for both
ChatResultandTextResultthat has one to one reference to thechoicedetails coming from the LLM.Updated GetModelResult example with the expected behavior and an easier example to track the changes and different prompts.
Contribution Checklist