Skip to content

.Net Notebooks: associate Azure OpenAI endpoints with kernel#2042

Merged
shawncal merged 6 commits intomicrosoft:mainfrom
arafattehsin:main
Aug 4, 2023
Merged

.Net Notebooks: associate Azure OpenAI endpoints with kernel#2042
shawncal merged 6 commits intomicrosoft:mainfrom
arafattehsin:main

Conversation

@arafattehsin
Copy link
Contributor

Motivation and Context

  1. Why is this change required?
    It fixes an important issue of missing an Azure OpenAI endpoint

  2. What scenario does it contribute to?
    Sample Notebooks

Description

I've just associated the Azure OpenAI endpoints.

Contribution Checklist

@arafattehsin arafattehsin requested a review from a team as a code owner July 18, 2023 12:21
@shawncal shawncal added the PR: feedback to address Waiting for PR owner to address comments/questions label Jul 21, 2023
@shawncal shawncal changed the title fix: associate Azure OpenAI endpoints with kernel .Net Notebooks: associate Azure OpenAI endpoints with kernel Jul 21, 2023
remove orgid from Azure OpenAI Endpoint

Co-authored-by: Shawn Callegari <36091529+shawncal@users.noreply.github.com>
@shawncal shawncal added PR: ready for review All feedback addressed, ready for reviews and removed PR: feedback to address Waiting for PR owner to address comments/questions labels Aug 4, 2023
@shawncal shawncal enabled auto-merge August 4, 2023 03:58
@shawncal shawncal added this pull request to the merge queue Aug 4, 2023
Merged via the queue into microsoft:main with commit 1657f93 Aug 4, 2023
SOE-YoungS pushed a commit to SOE-YoungS/semantic-kernel that referenced this pull request Nov 1, 2023
…ft#2042)

### Motivation and Context

1. Why is this change required?
It fixes an important issue of missing an Azure OpenAI endpoint

2. What scenario does it contribute to?
Sample Notebooks

### Description

I've just associated the Azure OpenAI endpoints.

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#dev-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄

---------

Co-authored-by: Shawn Callegari <36091529+shawncal@users.noreply.github.com>
Co-authored-by: Gil LaHaye <gillahaye@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: ready for review All feedback addressed, ready for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants