Name refactoring + move OpenAI code to Connectors namespace#204
Merged
dluc merged 1 commit intomicrosoft:mainfrom Mar 30, 2023
Merged
Name refactoring + move OpenAI code to Connectors namespace#204dluc merged 1 commit intomicrosoft:mainfrom
dluc merged 1 commit intomicrosoft:mainfrom
Conversation
34d4900 to
c3be718
Compare
dmytrostruk
reviewed
Mar 29, 2023
dotnet/src/Connectors/Connectors.UnitTests/OpenAI/KernelConfigTests.cs
Outdated
Show resolved
Hide resolved
dotnet/src/SemanticKernel/SemanticFunctions/PromptTemplateConfig.cs
Outdated
Show resolved
Hide resolved
2786b9d to
3032035
Compare
dotnet/src/Connectors/Connectors.OpenAI/Connectors.OpenAI.csproj
Outdated
Show resolved
Hide resolved
dmytrostruk
reviewed
Mar 30, 2023
b1439f6 to
25b917d
Compare
1ac3458 to
43fde55
Compare
dotnet/src/Connectors/Connectors.UnitTests/OpenAI/KernelConfigOpenAIExtensionsTests.cs
Show resolved
Hide resolved
awharrison-28
previously approved these changes
Mar 30, 2023
lemillermicrosoft
previously approved these changes
Mar 30, 2023
Add OpenAI connector Label => Service Id Backend => Service / Connector EmbeddingGenerator => EmbeddingGeneration / TextEmbeddingGeneration Improve extension methods namespaces to reduce "using" statements Prompt config: rename "default_backends" to "default_services"
6d4decd
lemillermicrosoft
approved these changes
Mar 30, 2023
dehoward
pushed a commit
to lemillermicrosoft/semantic-kernel
that referenced
this pull request
Jun 1, 2023
…t#204) ### Motivation and Context Cleaning up tech debt as per plan, last couple of months * Moved OpenAI code to Connectors namespace * Label => Service Id * Backend => Service / Connector * EmbeddingGenerator => EmbeddingGeneration / TextEmbeddingGeneration
johnoliver
pushed a commit
to johnoliver/semantic-kernel
that referenced
this pull request
Jun 5, 2024
…t#204) ### Motivation and Context Cleaning up tech debt as per plan, last couple of months * Moved OpenAI code to Connectors namespace * Label => Service Id * Backend => Service / Connector * EmbeddingGenerator => EmbeddingGeneration / TextEmbeddingGeneration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Cleaning up tech debt as per plan, last couple of months