Skip to content

Update links in Connectors.Memory.Redis README#1852

Merged
shawncal merged 1 commit intomicrosoft:mainfrom
gitri-ms:broken-link
Jul 5, 2023
Merged

Update links in Connectors.Memory.Redis README#1852
shawncal merged 1 commit intomicrosoft:mainfrom
gitri-ms:broken-link

Conversation

@gitri-ms
Copy link
Contributor

@gitri-ms gitri-ms commented Jul 5, 2023

Motivation and Context

One of the links in the Redis Connector README is broken, causing one of our workflows to fail and block PRs.

Description

Update the link, as well as a couple others that were redirecting.

Contribution Checklist

@gitri-ms gitri-ms requested a review from a team as a code owner July 5, 2023 18:46
@gitri-ms gitri-ms added the docs and tests Improvements or additions to documentation label Jul 5, 2023
@github-actions github-actions bot added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel memory connector labels Jul 5, 2023
@gitri-ms gitri-ms requested a review from shawncal July 5, 2023 20:12
@shawncal shawncal added this pull request to the merge queue Jul 5, 2023
Merged via the queue into microsoft:main with commit eac21ed Jul 5, 2023
shawncal pushed a commit to shawncal/semantic-kernel that referenced this pull request Jul 6, 2023
### Motivation and Context
<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
One of the links in the Redis Connector README is broken, causing one of
our workflows to fail and block PRs.

### Description
<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->
Update the link, as well as a couple others that were redirecting.

### Contribution Checklist
<!-- Before submitting this PR, please make sure: -->
- [x] The code builds clean without any errors or warnings
- [x] The PR follows SK Contribution Guidelines
(https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
- [x] The code follows the .NET coding conventions
(https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions)
verified with `dotnet format`
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄
@gitri-ms gitri-ms deleted the broken-link branch July 17, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs and tests Improvements or additions to documentation kernel Issues or pull requests impacting the core kernel memory connector .NET Issue or Pull requests regarding .NET code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants