Fixed function parameter not being used for LoadFromFile#1803
Merged
shawncal merged 2 commits intomicrosoft:mainfrom Jul 3, 2023
Chinouchi:fix/settings-reader-specific-file
Merged
Fixed function parameter not being used for LoadFromFile#1803shawncal merged 2 commits intomicrosoft:mainfrom Chinouchi:fix/settings-reader-specific-file
shawncal merged 2 commits intomicrosoft:mainfrom
Chinouchi:fix/settings-reader-specific-file
Conversation
glahaye
approved these changes
Jul 1, 2023
dehoward
approved these changes
Jul 3, 2023
shawncal
approved these changes
Jul 3, 2023
shawncal
added a commit
to shawncal/semantic-kernel
that referenced
this pull request
Jul 6, 2023
) ### Motivation and Context While trying to reuse the Settings class used in the C# notebooks to load the Kernel configuration, I saw the parameter to specify a file was not properly used. ### Description Very simple changes as I just updated the code to use the function parameter instead of the Class variable Default It is in the notebook part so no build nor tests. Notebooks are still working. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [x] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 Co-authored-by: Shawn Callegari <36091529+shawncal@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
While trying to reuse the Settings class used in the C# notebooks to load the Kernel configuration, I saw the parameter to specify a file was not properly used.
Description
Very simple changes as I just updated the code to use the function parameter instead of the Class variable Default
It is in the notebook part so no build nor tests. Notebooks are still working.
Contribution Checklist
dotnet format