Merged
Conversation
80b0a3f to
7d73b22
Compare
e8bea66 to
4e5177c
Compare
Member
|
Should fix #1810 |
dmytrostruk
reviewed
Jul 3, 2023
Member
dmytrostruk
left a comment
There was a problem hiding this comment.
@JadynWong Thank you for this improvement, looks great!
I left small comments, as soon as they are resolved, we can merge this to main.
I verified the changes with integration tests and Example39_Postgres locally - works as expected.
dotnet/src/Connectors/Connectors.Memory.Postgres/IPostgresDbClient.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.Memory.Postgres/PostgresDbClient.cs
Outdated
Show resolved
Hide resolved
shawncal
approved these changes
Jul 3, 2023
shawncal
pushed a commit
to shawncal/semantic-kernel
that referenced
this pull request
Jul 6, 2023
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Follow microsoft#1735 (review) advice to rename methods and separate responsibilities. ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> - Separate the responsibilities of PostgresMemoryStore and PostgresDbClient. - Add the real batch methods to PostgresDbClient. - Save timestamp with `TIMESTAMP WITH TIME ZONE` type - Stop creating index ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [x] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Dmytro Struk <13853051+dmytrostruk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Follow #1735 (review) advice to rename methods and separate responsibilities.
Description
TIMESTAMP WITH TIME ZONEtypeContribution Checklist
dotnet format