Skip to content

Copilot Chat: align bash deploy-webapi script with powershell#1786

Merged
alliscode merged 1 commit intomicrosoft:mainfrom
dehoward:align-bash-deploy-webapi-to-ps1
Jun 30, 2023
Merged

Copilot Chat: align bash deploy-webapi script with powershell#1786
alliscode merged 1 commit intomicrosoft:mainfrom
dehoward:align-bash-deploy-webapi-to-ps1

Conversation

@dehoward
Copy link

Motivation and Context

I noticed the script was slightly misaligned during my deployment of webapi.

Description

corrects the usage string and sets a default value for the PACKAGE_FILE_PATH similar to the Powershell script.

Contribution Checklist

@dehoward dehoward requested a review from a team as a code owner June 30, 2023 04:02
@dehoward dehoward self-assigned this Jun 30, 2023
@alliscode alliscode added this pull request to the merge queue Jun 30, 2023
Merged via the queue into microsoft:main with commit 3105aa1 Jun 30, 2023
markwallace-microsoft pushed a commit to markwallace-microsoft/semantic-kernel that referenced this pull request Jul 3, 2023
…oft#1786)

### Motivation and Context
<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
I noticed the script was slightly misaligned during my deployment of
webapi.

### Description
<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->
corrects the usage string and sets a default value for the
`PACKAGE_FILE_PATH` similar to the Powershell script.

### Contribution Checklist
<!-- Before submitting this PR, please make sure: -->
- [X] The code builds clean without any errors or warnings
- [X] The PR follows SK Contribution Guidelines
(https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
- [X] The code follows the .NET coding conventions
(https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions)
verified with `dotnet format`
- [X] All unit tests pass, and I have added new tests where possible
- [X] I didn't break anyone 😄
shawncal pushed a commit to shawncal/semantic-kernel that referenced this pull request Jul 6, 2023
…oft#1786)

### Motivation and Context
<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
I noticed the script was slightly misaligned during my deployment of
webapi.

### Description
<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->
corrects the usage string and sets a default value for the
`PACKAGE_FILE_PATH` similar to the Powershell script.

### Contribution Checklist
<!-- Before submitting this PR, please make sure: -->
- [X] The code builds clean without any errors or warnings
- [X] The PR follows SK Contribution Guidelines
(https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
- [X] The code follows the .NET coding conventions
(https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions)
verified with `dotnet format`
- [X] All unit tests pass, and I have added new tests where possible
- [X] I didn't break anyone 😄
golden-aries pushed a commit to golden-aries/semantic-kernel that referenced this pull request Oct 10, 2023
…oft#1786)

### Motivation and Context
<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
I noticed the script was slightly misaligned during my deployment of
webapi.

### Description
<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->
corrects the usage string and sets a default value for the
`PACKAGE_FILE_PATH` similar to the Powershell script.

### Contribution Checklist
<!-- Before submitting this PR, please make sure: -->
- [X] The code builds clean without any errors or warnings
- [X] The PR follows SK Contribution Guidelines
(https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
- [X] The code follows the .NET coding conventions
(https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions)
verified with `dotnet format`
- [X] All unit tests pass, and I have added new tests where possible
- [X] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants