Feature/notebook bing search#1729
Merged
gitri-ms merged 20 commits intomicrosoft:mainfrom Jul 5, 2023
Merged
Conversation
added 4 commits
June 22, 2023 15:08
…into feature/notebook_bing_search
…into feature/notebook_bing_search
gitri-ms
requested changes
Jun 28, 2023
samples/notebooks/dotnet/09-BingSearch-using-kernel-prince.ipynb
Outdated
Show resolved
Hide resolved
samples/notebooks/dotnet/09-BingSearch-using-kernel-prince.ipynb
Outdated
Show resolved
Hide resolved
samples/notebooks/dotnet/09-BingSearch-using-kernel-prince.ipynb
Outdated
Show resolved
Hide resolved
samples/notebooks/dotnet/09-BingSearch-using-kernel-prince.ipynb
Outdated
Show resolved
Hide resolved
samples/notebooks/dotnet/09-BingSearch-using-kernel-prince.ipynb
Outdated
Show resolved
Hide resolved
samples/notebooks/dotnet/09-BingSearch-using-kernel-prince.ipynb
Outdated
Show resolved
Hide resolved
samples/notebooks/dotnet/09-BingSearch-using-kernel-prince.ipynb
Outdated
Show resolved
Hide resolved
samples/notebooks/dotnet/09-BingSearch-using-kernel-prince.ipynb
Outdated
Show resolved
Hide resolved
added 3 commits
June 29, 2023 12:33
Contributor
Author
|
@microsoft-github-policy-service agree |
Fix minor mistakes in the notebook
…into feature/notebook_bing_search
Contributor
Author
|
Make tweaks as asked. @gitri-ms let me know is any more amends have to be make. |
gitri-ms
requested changes
Jul 3, 2023
Contributor
|
Hi @N-E-W-T-O-N -- thanks for the updates! I did another review pass, it's looking pretty good but a few more things to address. I also need to do a full test pass on all the notebooks to make sure the version upgrade doesn't break anything before I can merge this in -- will get that done today. Thanks for all your work, and looking forward to bringing this change in! |
Contributor
Author
|
Updated the branch. |
gitri-ms
approved these changes
Jul 5, 2023
Contributor
|
Thanks @N-E-W-T-O-N for your contribution to our samples! |
Contributor
Author
|
Thank you @gitri-ms to be patience withme .This is my first ever contribution in a big project. |
shawncal
pushed a commit
to shawncal/semantic-kernel
that referenced
this pull request
Jul 6, 2023
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> ### Description I have added a new notebook to show how to bring search functionality in SK ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [x] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: newton.mallick <newton.mallick@celebaltech.com> Co-authored-by: Gina Triolo <51341242+gitri-ms@users.noreply.github.com>
johnoliver
pushed a commit
to johnoliver/semantic-kernel
that referenced
this pull request
Jun 5, 2024
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> ### Description I have added a new notebook to show how to bring search functionality in SK ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [x] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: newton.mallick <newton.mallick@celebaltech.com> Co-authored-by: Gina Triolo <51341242+gitri-ms@users.noreply.github.com>
johnoliver
pushed a commit
to johnoliver/semantic-kernel
that referenced
this pull request
Jun 5, 2024
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> ### Description I have added a new notebook to show how to bring search functionality in SK ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [x] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: newton.mallick <newton.mallick@celebaltech.com> Co-authored-by: Gina Triolo <51341242+gitri-ms@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Description
I have added a new notebook to show how to bring search functionality in SK
Contribution Checklist
dotnet format