Skip to content

Java: Add sequential planner#1526

Merged
johnoliver merged 21 commits intomicrosoft:experimental-javafrom
johnoliver:planner-rework-import-3
Jul 5, 2023
Merged

Java: Add sequential planner#1526
johnoliver merged 21 commits intomicrosoft:experimental-javafrom
johnoliver:planner-rework-import-3

Conversation

@johnoliver
Copy link
Member

Motivation and Context

Description

Contribution Checklist

@johnoliver johnoliver force-pushed the planner-rework-import-3 branch 3 times, most recently from 7060837 to 8ddb303 Compare June 20, 2023 14:22
@johnoliver johnoliver force-pushed the planner-rework-import-3 branch from 8ddb303 to b36275e Compare June 20, 2023 14:29
@johnoliver johnoliver changed the title Java - Draft to show example of sequential parser Java - Add sequential parser Jun 20, 2023
@johnoliver johnoliver changed the title Java - Add sequential parser Java - Add sequential planner Jun 20, 2023
@johnoliver johnoliver marked this pull request as ready for review June 20, 2023 14:34
@brunoborges
Copy link
Member

/spotless

@github-actions
Copy link

Already up-to-date

@brunoborges
Copy link
Member

/spotless

@johnoliver
Copy link
Member Author

fixes #1599

@johnoliver
Copy link
Member Author

fixes #1600

@johnoliver johnoliver self-assigned this Jun 21, 2023
@johnoliver johnoliver requested a review from a team as a code owner June 21, 2023 12:49
Copy link
Member

@markwallace-microsoft markwallace-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review of the first 39 files in this PR. Will continue this tomorrow.

@shawncal shawncal force-pushed the planner-rework-import-3 branch from 9d926a1 to a55af59 Compare June 22, 2023 00:09
@markwallace-microsoft markwallace-microsoft added the java Issue or PR regarding Java code label Jun 22, 2023
@shawncal shawncal changed the title Java - Add sequential planner Java: Add sequential planner Jun 29, 2023
@johnoliver
Copy link
Member Author

Fixes #1753 #1750 #1754 #1599

@markwallace-microsoft
Copy link
Member

/spotless

@github-actions
Copy link

github-actions bot commented Jul 3, 2023

Already up-to-date

@markwallace-microsoft
Copy link
Member

/spotless

@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Already up-to-date

@johnoliver johnoliver merged commit 152593e into microsoft:experimental-java Jul 5, 2023
johnoliver added a commit to johnoliver/semantic-kernel that referenced this pull request Jun 5, 2024
### Motivation and Context
<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->


### Description
<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->


### Contribution Checklist
<!-- Before submitting this PR, please make sure: -->
- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows SK Contribution Guidelines
(https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
- [ ] The code follows the .NET coding conventions
(https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions)
verified with `dotnet format`
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
johnoliver added a commit to johnoliver/semantic-kernel that referenced this pull request Jun 5, 2024
### Motivation and Context
<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->


### Description
<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->


### Contribution Checklist
<!-- Before submitting this PR, please make sure: -->
- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows SK Contribution Guidelines
(https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
- [ ] The code follows the .NET coding conventions
(https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions)
verified with `dotnet format`
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

java Issue or PR regarding Java code

Projects

No open projects
Status: Sprint: Done

Development

Successfully merging this pull request may close these issues.

5 participants