Http consistency: Weaviate#1479
Merged
lemillermicrosoft merged 5 commits intomicrosoft:mainfrom Jun 15, 2023
Merged
Conversation
dotnet/src/Connectors/Connectors.Memory.Weaviate/WeaviateKernelBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.Memory.Weaviate/WeaviateMemoryStore.cs
Outdated
Show resolved
Hide resolved
lemillermicrosoft
previously approved these changes
Jun 14, 2023
dotnet/src/Connectors/Connectors.Memory.Weaviate/WeaviateKernelBuilderExtensions.cs
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.Memory.Weaviate/WeaviateKernelBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.Memory.Weaviate/WeaviateMemoryStore.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.Memory.Weaviate/WeaviateMemoryStore.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.Memory.Weaviate/WeaviateMemoryStore.cs
Outdated
Show resolved
Hide resolved
lemillermicrosoft
approved these changes
Jun 14, 2023
shawncal
approved these changes
Jun 15, 2023
…yStore.cs Co-authored-by: Roger Barreto <19890735+RogerBarreto@users.noreply.github.com>
…yStore.cs Co-authored-by: Roger Barreto <19890735+RogerBarreto@users.noreply.github.com>
9a8d7e8 to
c3e4766
Compare
rogerbarreto
approved these changes
Jun 15, 2023
shawncal
pushed a commit
to shawncal/semantic-kernel
that referenced
this pull request
Jul 6, 2023
### Description This PR brings the following changes: - The constructors of the WeaviateMemoryStore class have been adjusted to match those of other connectors. - The KernelBuilder class has new extension methods called "With WeaviateMemoryStore" that simplify the registration of the Weaviate memory store. These methods align the registration process with other connector registrations, enforce the use of a HttpClient with the preconfigured retry handler, and allow the hosting application to provide a custom HttpClient if needed. - Minor bug fixes for WeaviateMemoryStore.GetAsync method and integration tests. --------- Co-authored-by: Roger Barreto <19890735+RogerBarreto@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR brings the following changes:
The constructors of the WeaviateMemoryStore class have been adjusted to match those of other connectors.
The KernelBuilder class has new extension methods called "With WeaviateMemoryStore" that simplify the registration of the Weaviate memory store. These methods align the registration process with other connector registrations, enforce the use of a HttpClient with the preconfigured retry handler, and allow the hosting application to provide a custom HttpClient if needed.
Minor bug fixes for WeaviateMemoryStore.GetAsync method and integration tests.
Contribution Checklist
dotnet format