.Net: Optimize and clean up the PgVector provider#12441
Merged
markwallace-microsoft merged 1 commit intomicrosoft:mainfrom Jun 19, 2025
Merged
.Net: Optimize and clean up the PgVector provider#12441markwallace-microsoft merged 1 commit intomicrosoft:mainfrom
markwallace-microsoft merged 1 commit intomicrosoft:mainfrom
Conversation
westey-m
reviewed
Jun 13, 2025
westey-m
approved these changes
Jun 13, 2025
dmytrostruk
approved these changes
Jun 18, 2025
shethaadit
approved these changes
Jun 18, 2025
dmytrostruk
approved these changes
Jun 18, 2025
Member
|
Unrelated integration test failure |
jcruzmot-te
pushed a commit
to thousandeyes/aia-semantic-kernel
that referenced
this pull request
Sep 15, 2025
* Removed the intermediate `Dictionary<string, object?>` in
serialization/deserialization. Like with SQL Server and SQLite, we now
deserialize directly from NpgsqlDataReader, etc.
* Removed PostgresSqlCommandInfo, which was basically the same thing as
NpgsqlCommand. Code now simply instantiates NpgsqlCommand directly,
instead of instantiating PostgresSqlCommandInfo and then creating an
NpgsqlCommand from that.
* Removed PostgresDbClient - command creation is now done in
PostgresCollection directly (actual SQL is still generated
PostgresSqlBuilder for unit testing, at least for now).
* Moved the reference-counting functionality of PostgresDbClient to a
minimal `NpgsqlDataSourceArc` ("atomic reference counter"), which does
only this.
* Various other minor cleanups.
Closes microsoft#11123
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dictionary<string, object?>in serialization/deserialization. Like with SQL Server and SQLite, we now deserialize directly from NpgsqlDataReader, etc.NpgsqlDataSourceArc("atomic reference counter"), which does only this.Closes #11123