.Net: Remove SqlDataReaderDictionary in SQL Server provider#12241
Merged
roji merged 3 commits intomicrosoft:mainfrom May 23, 2025
Merged
.Net: Remove SqlDataReaderDictionary in SQL Server provider#12241roji merged 3 commits intomicrosoft:mainfrom
roji merged 3 commits intomicrosoft:mainfrom
Conversation
roji
commented
May 22, 2025
dotnet/src/Connectors/Connectors.Memory.SqlServer/SqlServerCollection.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.Memory.SqlServer/SqlServerCollection.cs
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.Memory.SqlServer/SqlServerCommandBuilder.cs
Show resolved
Hide resolved
dotnet/src/Connectors/VectorData.Abstractions/ProviderServices/PropertyModel.cs
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.Memory.SqlServer/SqlServerCommandBuilder.cs
Show resolved
Hide resolved
adamsitnik
approved these changes
May 23, 2025
Member
adamsitnik
left a comment
There was a problem hiding this comment.
Very nice! Thank you @roji 👍
dotnet/src/Connectors/Connectors.Memory.SqlServer/SqlServerCommandBuilder.cs
Show resolved
Hide resolved
westey-m
reviewed
May 23, 2025
dotnet/src/VectorDataIntegrationTests/SqlServerIntegrationTests/SqlServerVectorStoreTests.cs
Outdated
Show resolved
Hide resolved
westey-m
approved these changes
May 23, 2025
westey-m
approved these changes
May 23, 2025
westey-m
approved these changes
May 23, 2025
eavanvalkenburg
pushed a commit
that referenced
this pull request
May 26, 2025
We currently write records to the database by first serializing them to a Dictionary, and then writing that Dictionary out as SqlParameters on the command. Similarly, we read records by allocating and populating a Dictionary, only to then iterate over that Dictionary and populate the .NET instance from it. This PR does away with the intermediate Dictionary representation. This optimizes serialization by removing the double-copy, reduces allocations, opens the way for boxing-free serialization, and also just simplifies the code (less conversions and stuff to follow).
jcruzmot-te
pushed a commit
to thousandeyes/aia-semantic-kernel
that referenced
this pull request
Sep 15, 2025
…t#12241) We currently write records to the database by first serializing them to a Dictionary, and then writing that Dictionary out as SqlParameters on the command. Similarly, we read records by allocating and populating a Dictionary, only to then iterate over that Dictionary and populate the .NET instance from it. This PR does away with the intermediate Dictionary representation. This optimizes serialization by removing the double-copy, reduces allocations, opens the way for boxing-free serialization, and also just simplifies the code (less conversions and stuff to follow).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently write records to the database by first serializing them to a Dictionary, and then writing that Dictionary out as SqlParameters on the command. Similarly, we read records by allocating and populating a Dictionary, only to then iterate over that Dictionary and populate the .NET instance from it.
This PR does away with the intermediate Dictionary representation. This optimizes serialization by removing the double-copy, reduces allocations, opens the way for boxing-free serialization, and also just simplifies the code (less conversions and stuff to follow).
Part of #11123