Skip to content

Python: Use BaseModel instead of KernelBaseModel in samples#12224

Merged
eavanvalkenburg merged 1 commit intomainfrom
taochen/python-switch-to-base-model
May 22, 2025
Merged

Python: Use BaseModel instead of KernelBaseModel in samples#12224
eavanvalkenburg merged 1 commit intomainfrom
taochen/python-switch-to-base-model

Conversation

@TaoChenOSU
Copy link
Contributor

@TaoChenOSU TaoChenOSU commented May 21, 2025

Motivation and Context

It's unnecessary to use KernelBaseModel in the samples.

Description

Switch to BaseModel.

Contribution Checklist

@TaoChenOSU TaoChenOSU self-assigned this May 21, 2025
@TaoChenOSU TaoChenOSU requested a review from a team as a code owner May 21, 2025 19:03
@TaoChenOSU TaoChenOSU added python Pull requests for the Python Semantic Kernel agents labels May 21, 2025
@github-actions github-actions bot changed the title Use BaseModel instead of KernelBaseModel in samples Python: Use BaseModel instead of KernelBaseModel in samples May 21, 2025
@eavanvalkenburg eavanvalkenburg force-pushed the taochen/python-switch-to-base-model branch from 8de5333 to d6e5249 Compare May 22, 2025 04:31
@eavanvalkenburg eavanvalkenburg enabled auto-merge May 22, 2025 04:31
@eavanvalkenburg eavanvalkenburg added this pull request to the merge queue May 22, 2025
Merged via the queue into main with commit 7243188 May 22, 2025
27 checks passed
@eavanvalkenburg eavanvalkenburg deleted the taochen/python-switch-to-base-model branch May 22, 2025 04:45
@github-project-automation github-project-automation bot moved this to Sprint: Done in Semantic Kernel May 22, 2025
jcruzmot-te pushed a commit to thousandeyes/aia-semantic-kernel that referenced this pull request Sep 15, 2025
…t#12224)

### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
It's unnecessary to use `KernelBaseModel` in the samples.

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->
Switch to `BaseModel`.


### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agents python Pull requests for the Python Semantic Kernel

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants