Python: Add missing fields to AzureAIAgentSettings#12211
Merged
eavanvalkenburg merged 1 commit intomicrosoft:mainfrom May 21, 2025
Merged
Python: Add missing fields to AzureAIAgentSettings#12211eavanvalkenburg merged 1 commit intomicrosoft:mainfrom
AzureAIAgentSettings#12211eavanvalkenburg merged 1 commit intomicrosoft:mainfrom
Conversation
AzureAIAgentSettingsAzureAIAgentSettings
moonbox3
approved these changes
May 21, 2025
Collaborator
moonbox3
left a comment
There was a problem hiding this comment.
Thanks for including @KanchiShimono. These can also passed in via extras dict, but yeah, they should be here, too. Appreciate the support.
Member
Python Unit Test Overview
|
eavanvalkenburg
approved these changes
May 21, 2025
jcruzmot-te
pushed a commit
to thousandeyes/aia-semantic-kernel
that referenced
this pull request
Sep 15, 2025
### Motivation and Context Some fields were missing from `AzureAIAgentSettings`, which caused errors during placeholder replacement in the declarative agent. https://github.com/microsoft/semantic-kernel/blob/6efcc847c56d742a12dec871bd715319a599533c/python/semantic_kernel/agents/azure_ai/azure_ai_agent.py#L568-L575 ### Description - Add the missing fields to `AzureAIAgentSettings`. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Some fields were missing from
AzureAIAgentSettings, which caused errors during placeholder replacement in the declarative agent.semantic-kernel/python/semantic_kernel/agents/azure_ai/azure_ai_agent.py
Lines 568 to 575 in 6efcc84
Description
AzureAIAgentSettings.Contribution Checklist