Skip to content

.Net: Fix BaseTest#12208

Merged
TaoChenOSU merged 1 commit intomainfrom
taochen/dotnet-fix-base-test
May 21, 2025
Merged

.Net: Fix BaseTest#12208
TaoChenOSU merged 1 commit intomainfrom
taochen/dotnet-fix-base-test

Conversation

@TaoChenOSU
Copy link
Contributor

@TaoChenOSU TaoChenOSU commented May 21, 2025

Motivation and Context

We are seeing exceptions in some samples due to a bug in the BaseTest.cs module, that ignores the modelName parameter when creating a kernel with chat completion.

Description

This PR ensures that the modelName parameter is consistently passed to the AddChatCompletionToKernel method.

Contribution Checklist

@TaoChenOSU TaoChenOSU self-assigned this May 21, 2025
@TaoChenOSU TaoChenOSU requested a review from a team as a code owner May 21, 2025 04:28
@TaoChenOSU TaoChenOSU added the .NET Issue or Pull requests regarding .NET code label May 21, 2025
@TaoChenOSU TaoChenOSU requested a review from crickman May 21, 2025 04:28
@github-actions github-actions bot changed the title Fix BaseTest .Net: Fix BaseTest May 21, 2025
@TaoChenOSU TaoChenOSU enabled auto-merge May 21, 2025 17:07
@TaoChenOSU TaoChenOSU added this pull request to the merge queue May 21, 2025
Merged via the queue into main with commit da74476 May 21, 2025
21 checks passed
@TaoChenOSU TaoChenOSU deleted the taochen/dotnet-fix-base-test branch May 21, 2025 17:26
@github-project-automation github-project-automation bot moved this to Sprint: Done in Semantic Kernel May 21, 2025
jcruzmot-te pushed a commit to thousandeyes/aia-semantic-kernel that referenced this pull request Sep 15, 2025
### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
We are seeing exceptions in some samples due to a bug in the
`BaseTest.cs` module, that ignores the `modelName` parameter when
creating a kernel with chat completion.

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->
This PR ensures that the `modelName` parameter is consistently passed to
the `AddChatCompletionToKernel` method.

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

.NET Issue or Pull requests regarding .NET code

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants