.Net: Remove Record from abstraction type names #11832
Merged
roji merged 4 commits intomicrosoft:feature-vector-data-preb3from May 2, 2025
Merged
.Net: Remove Record from abstraction type names #11832roji merged 4 commits intomicrosoft:feature-vector-data-preb3from
roji merged 4 commits intomicrosoft:feature-vector-data-preb3from
Conversation
dbfcc44 to
bf22ec7
Compare
roji
commented
May 1, 2025
...et/src/Connectors/VectorData.Abstractions/ConnectorSupport/VectorStoreVectorPropertyModel.cs
Outdated
Show resolved
Hide resolved
...rc/Connectors/VectorData.Abstractions/RecordAttributes/VectorStoreVectorPropertyAttribute.cs
Outdated
Show resolved
Hide resolved
westey-m
reviewed
May 2, 2025
...rc/Connectors/Connectors.AzureAISearch.UnitTests/AzureAISearchDynamicDataModelMapperTests.cs
Outdated
Show resolved
Hide resolved
westey-m
approved these changes
May 2, 2025
adamsitnik
pushed a commit
that referenced
this pull request
May 5, 2025
Following #11832, this shortens the names of provider implementation types as discussed in API review (e.g. AzureCosmosDBMongoDBVectorStoreRecordCollection -> CosmosMongoCollection) * For Cosmos, I've left CosmosMongo vs. CosmosNoSql (note lower-case Sql rather than the previous SQL) to disambiguate, as discussed in API review. * We could also shorten PostgresVectorStore to PostgresStore (similar to how we have PostgresCollection now). For now I'm leaving PostgresVectorStore - we can discuss. * No namespaces/nuget package names are touched - I'll do this in a later PR. Closes #11230
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this PR is based on top of #11823, review last commit onlyThis applies naming changes discussed in API review (plus some other minor ones which align). To avoid huge PRs, this only touches the abstraction types, and not implementation types (I'll do this in a later PR).
Recordfrom names (i.e. this represents a "data property in a vector store" just like IVectorStoreCollection represents a "collection in a vector store").Part of #11230