Using BaseService as parent class for DocumentImportService#1171
Merged
adrianwyatt merged 2 commits intomicrosoft:mainfrom May 22, 2023
Merged
Using BaseService as parent class for DocumentImportService#1171adrianwyatt merged 2 commits intomicrosoft:mainfrom
adrianwyatt merged 2 commits intomicrosoft:mainfrom
Conversation
hathind-ms
approved these changes
May 22, 2023
TaoChenOSU
approved these changes
May 22, 2023
hathind-ms
approved these changes
May 22, 2023
shawncal
pushed a commit
to shawncal/semantic-kernel
that referenced
this pull request
Jul 6, 2023
…t#1171) ### Motivation and Context DocumentImportService needs to extend BaseService to get all the auth / header handling implemented in the parent.
golden-aries
pushed a commit
to golden-aries/semantic-kernel
that referenced
this pull request
Oct 10, 2023
…t#1171) ### Motivation and Context DocumentImportService needs to extend BaseService to get all the auth / header handling implemented in the parent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
DocumentImportService needs to extend BaseService to get all the auth / header handling implemented in the parent.