Skip to content

Python: Correct function name#1157

Merged
lemillermicrosoft merged 4 commits intomicrosoft:mainfrom
riedgar-ms:patch-1
May 22, 2023
Merged

Python: Correct function name#1157
lemillermicrosoft merged 4 commits intomicrosoft:mainfrom
riedgar-ms:patch-1

Conversation

@riedgar-ms
Copy link
Contributor

Motivation and Context

In the Python BasicPlanner one of the examples has a 'translate' function, but doesn't quite reference it correctly in the JSON output.

Description

The overall approach is to make the various parts of the few-shot example in the prompt self-consistent.

Contribution Checklist

Incorrect function name in the basic planner
@github-actions github-actions bot added the python Pull requests for the Python Semantic Kernel label May 22, 2023
@alexchaomander alexchaomander self-requested a review May 22, 2023 19:30
Copy link
Contributor

@alexchaomander alexchaomander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thank you for fixing this!

@alexchaomander alexchaomander added the PR: ready to merge PR has been approved by all reviewers, and is ready to merge. label May 22, 2023
@alexchaomander alexchaomander changed the title Correct function name Python: Correct function name May 22, 2023
@lemillermicrosoft lemillermicrosoft merged commit e9bb05e into microsoft:main May 22, 2023
@riedgar-ms riedgar-ms deleted the patch-1 branch May 22, 2023 21:01
shawncal pushed a commit to shawncal/semantic-kernel that referenced this pull request Jul 6, 2023
### Motivation and Context
In the Python `BasicPlanner` one of the examples has a 'translate'
function, but doesn't quite reference it correctly in the JSON output.

### Description
The overall approach is to make the various parts of the few-shot
example in the prompt self-consistent.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: ready to merge PR has been approved by all reviewers, and is ready to merge. python Pull requests for the Python Semantic Kernel

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants