Skip to content

Fix Yarn link and add QnA in CopilotChat#1124

Merged
hathind-ms merged 1 commit intomicrosoft:mainfrom
Vivihung:yarn-link
May 20, 2023
Merged

Fix Yarn link and add QnA in CopilotChat#1124
hathind-ms merged 1 commit intomicrosoft:mainfrom
Vivihung:yarn-link

Conversation

@Vivihung
Copy link
Member

Motivation and Context

Copilot Chat uses packages that can only be supported by Yarn v1.x. However, we have multiple reported cases where customers follow the instructions to install the wrong version of Yarn that causes errors in the Copilot Chat app.

Description

  1. Update the Semantic Kernel top README to use classic Yarn installation link.
  2. Add Troubleshooting guidance for Yarn 2.x+ in Copilot Chat README.

Contribution Checklist

@Vivihung Vivihung requested a review from craigomatic May 20, 2023 01:42
@Vivihung Vivihung requested a review from adrianwyatt May 20, 2023 01:43
@Vivihung Vivihung added docs and tests Improvements or additions to documentation PR: ready for review All feedback addressed, ready for reviews and removed samples labels May 20, 2023
@lemillermicrosoft lemillermicrosoft added the PR: ready to merge PR has been approved by all reviewers, and is ready to merge. label May 20, 2023
@hathind-ms hathind-ms merged commit f627566 into microsoft:main May 20, 2023
shawncal pushed a commit to shawncal/semantic-kernel that referenced this pull request Jul 6, 2023
### Motivation and Context
Copilot Chat uses packages that can only be supported by Yarn v1.x.
However, we have multiple reported cases where customers follow the
instructions to install the wrong version of Yarn that causes errors in
the Copilot Chat app.


### Description
1. Update the Semantic Kernel top README to use classic Yarn
installation link.
2. Add Troubleshooting guidance for Yarn 2.x+ in Copilot Chat README.


### Contribution Checklist
<!-- Before submitting this PR, please make sure: -->
- [x] The code builds clean without any errors or warnings
- [x] The PR follows SK Contribution Guidelines
(https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
~- [ ] The code follows the .NET coding conventions
(https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions)
verified with `dotnet format`~
~- [ ] All unit tests pass, and I have added new tests where possible~
- [x] I didn't break anyone 😄
golden-aries pushed a commit to golden-aries/semantic-kernel that referenced this pull request Oct 10, 2023
### Motivation and Context
Copilot Chat uses packages that can only be supported by Yarn v1.x.
However, we have multiple reported cases where customers follow the
instructions to install the wrong version of Yarn that causes errors in
the Copilot Chat app.


### Description
1. Update the Semantic Kernel top README to use classic Yarn
installation link.
2. Add Troubleshooting guidance for Yarn 2.x+ in Copilot Chat README.


### Contribution Checklist
<!-- Before submitting this PR, please make sure: -->
- [x] The code builds clean without any errors or warnings
- [x] The PR follows SK Contribution Guidelines
(https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
~- [ ] The code follows the .NET coding conventions
(https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions)
verified with `dotnet format`~
~- [ ] All unit tests pass, and I have added new tests where possible~
- [x] I didn't break anyone 😄
johnoliver pushed a commit to johnoliver/semantic-kernel that referenced this pull request Jun 5, 2024
### Motivation and Context
Copilot Chat uses packages that can only be supported by Yarn v1.x.
However, we have multiple reported cases where customers follow the
instructions to install the wrong version of Yarn that causes errors in
the Copilot Chat app.


### Description
1. Update the Semantic Kernel top README to use classic Yarn
installation link.
2. Add Troubleshooting guidance for Yarn 2.x+ in Copilot Chat README.


### Contribution Checklist
<!-- Before submitting this PR, please make sure: -->
- [x] The code builds clean without any errors or warnings
- [x] The PR follows SK Contribution Guidelines
(https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
~- [ ] The code follows the .NET coding conventions
(https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions)
verified with `dotnet format`~
~- [ ] All unit tests pass, and I have added new tests where possible~
- [x] I didn't break anyone 😄
johnoliver pushed a commit to johnoliver/semantic-kernel that referenced this pull request Jun 5, 2024
### Motivation and Context
Copilot Chat uses packages that can only be supported by Yarn v1.x.
However, we have multiple reported cases where customers follow the
instructions to install the wrong version of Yarn that causes errors in
the Copilot Chat app.


### Description
1. Update the Semantic Kernel top README to use classic Yarn
installation link.
2. Add Troubleshooting guidance for Yarn 2.x+ in Copilot Chat README.


### Contribution Checklist
<!-- Before submitting this PR, please make sure: -->
- [x] The code builds clean without any errors or warnings
- [x] The PR follows SK Contribution Guidelines
(https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
~- [ ] The code follows the .NET coding conventions
(https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions)
verified with `dotnet format`~
~- [ ] All unit tests pass, and I have added new tests where possible~
- [x] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs and tests Improvements or additions to documentation PR: ready for review All feedback addressed, ready for reviews PR: ready to merge PR has been approved by all reviewers, and is ready to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants