Complete porting the various Blocks for Java#1108
Merged
markwallace-microsoft merged 17 commits intomicrosoft:experimental-javafrom May 23, 2023
Merged
Complete porting the various Blocks for Java#1108markwallace-microsoft merged 17 commits intomicrosoft:experimental-javafrom
markwallace-microsoft merged 17 commits intomicrosoft:experimental-javafrom
Conversation
markwallace-microsoft
requested changes
May 22, 2023
...e/src/main/java/com/microsoft/semantickernel/templateengine/DefaultPromptTemplateEngine.java
Show resolved
Hide resolved
...e/src/main/java/com/microsoft/semantickernel/templateengine/DefaultPromptTemplateEngine.java
Outdated
Show resolved
Hide resolved
...kernel-core/src/main/java/com/microsoft/semantickernel/templateengine/TemplateException.java
Show resolved
Hide resolved
...kernel-core/src/main/java/com/microsoft/semantickernel/templateengine/TemplateException.java
Show resolved
Hide resolved
...kernel-core/src/main/java/com/microsoft/semantickernel/templateengine/TemplateException.java
Show resolved
Hide resolved
...ickernel-core/src/main/java/com/microsoft/semantickernel/templateengine/blocks/ValBlock.java
Show resolved
Hide resolved
...ickernel-core/src/main/java/com/microsoft/semantickernel/templateengine/blocks/ValBlock.java
Outdated
Show resolved
Hide resolved
...ickernel-core/src/main/java/com/microsoft/semantickernel/templateengine/blocks/VarBlock.java
Outdated
Show resolved
Hide resolved
...ickernel-core/src/main/java/com/microsoft/semantickernel/templateengine/blocks/VarBlock.java
Show resolved
Hide resolved
...ickernel-core/src/main/java/com/microsoft/semantickernel/templateengine/blocks/VarBlock.java
Show resolved
Hide resolved
markwallace-microsoft
previously approved these changes
May 22, 2023
Member
markwallace-microsoft
left a comment
There was a problem hiding this comment.
There are still some suggestions to be committed
Member
Author
@markwallace-microsoft With the exception of the logger injection, I believe I have included everything, unfortunately I also accidentally merged in the code from #1131 to this branch including the fixes requested on #1131, I can try to separate the PRs again, however if you are satisfied that I have addressed the issues on #1131 can merge them both here |
…ernel/templateengine/TemplateException.java Co-authored-by: Mark Wallace <127216156+markwallace-microsoft@users.noreply.github.com>
…ernel/templateengine/TemplateException.java Co-authored-by: Mark Wallace <127216156+markwallace-microsoft@users.noreply.github.com>
…ernel/templateengine/TemplateException.java Co-authored-by: Mark Wallace <127216156+markwallace-microsoft@users.noreply.github.com>
…ernel/templateengine/TemplateException.java Co-authored-by: Mark Wallace <127216156+markwallace-microsoft@users.noreply.github.com>
…ernel/templateengine/TemplateException.java Co-authored-by: Mark Wallace <127216156+markwallace-microsoft@users.noreply.github.com>
…ernel/templateengine/TemplateException.java Co-authored-by: Mark Wallace <127216156+markwallace-microsoft@users.noreply.github.com>
…ernel/templateengine/TemplateException.java Co-authored-by: Mark Wallace <127216156+markwallace-microsoft@users.noreply.github.com>
…ernel/templateengine/TemplateException.java Co-authored-by: Mark Wallace <127216156+markwallace-microsoft@users.noreply.github.com>
…ernel/templateengine/TemplateException.java Co-authored-by: Mark Wallace <127216156+markwallace-microsoft@users.noreply.github.com>
Co-authored-by: Mark Wallace <127216156+markwallace-microsoft@users.noreply.github.com>
markwallace-microsoft
approved these changes
May 23, 2023
5 tasks
This was referenced Aug 1, 2023
johnoliver
added a commit
to johnoliver/semantic-kernel
that referenced
this pull request
Jun 5, 2024
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [ ] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄 --------- Co-authored-by: Mark Wallace <127216156+markwallace-microsoft@users.noreply.github.com>
johnoliver
added a commit
to johnoliver/semantic-kernel
that referenced
this pull request
Jun 5, 2024
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [ ] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄 --------- Co-authored-by: Mark Wallace <127216156+markwallace-microsoft@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Description
Contribution Checklist
dotnet format